scripts: isolate diffcheck temporary files #2338

pull fengxueweilai wants to merge 1 commits into bitcoin:master from fengxueweilai:my_feature changing 1 files +6 −3
  1. fengxueweilai commented at 9:50 AM on October 23, 2026: contributor

    scripts/diffcheck.sh writes fixed /tmp/table.mediawiki and /tmp/after.diff files. Concurrent checkouts can overwrite one another's inputs, and failed table generation does not stop the comparison.

    Create a private temporary directory per invocation, clean it on exit, and stop if buildtable fails.

  2. fix(scripts): isolate diffcheck temporary files
    Signed-off-by: fengxueweilai <fengxueweilai@outlook.com>
    9b1a7ef537
  3. jonatack commented at 11:13 PM on October 23, 2026: member

    ACK, thank you

  4. jonatack added the label CI on Oct 23, 2026
  5. jonatack renamed this:
    fix(scripts): isolate diffcheck temporary files
    scripts: isolate diffcheck temporary files
    on Oct 23, 2026
  6. jonatack merged this on Oct 23, 2026
  7. jonatack closed this on Oct 23, 2026

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-03 19:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me