BIP112: Update document to match implementation #248
pull btcdrak wants to merge 5 commits into bitcoin:master from btcdrak:bip112sync changing 1 files +92 −93-
btcdrak commented at 8:54 PM on November 23, 2015: contributor
-
BIP112: Update document to match implementation 4048f45316
- btcdrak force-pushed on Nov 23, 2015
- btcdrak cross-referenced this on Nov 23, 2015 from issue Correction related to nVersion by jl2012
- btcdrak cross-referenced this on Nov 23, 2015 from issue BIP-112: Mempool-only CHECKSEQUENCEVERIFY by maaku
- btcdrak force-pushed on Nov 24, 2015
- btcdrak force-pushed on Nov 24, 2015
- btcdrak force-pushed on Nov 24, 2015
-
More clearly define script execution failure pathway d30f1c6d0b
- btcdrak force-pushed on Nov 24, 2015
-
Fixup comment 8d85335f2a
-
NicolasDorier commented at 9:21 AM on November 25, 2015: contributor
Not good, remove:
Otherwise, script execution will continue as if a NOP had been executed.This is not true, if one of those conditions are true, then script fail. If none of them are true, then processing will continue as defined in this BIP.
The only condition this is considered a NOP is if SCRIPT_VERIFY_CHECKSEQUENCEVERIFY flag is disabled. Which is not worth mentioning in the BIP.
-
btcdrak commented at 1:48 PM on November 25, 2015: contributor
@NicolasDorier This is the same language used in BIP65. If the script does not fail, script execution continues as if a NOP had been executed.
-
NicolasDorier commented at 3:04 PM on November 25, 2015: contributor
Ok I see. Well, it is strange to say "executed as a NOP" as opposed to "the stack is not affected by this operation". "Executed as NOP" for me mean no verification for failure is even made.
It does not stop me from understanding just finding it weird. Not a stopper though, if nobody complains let's keep it like that.
-
0026fcb929
Use optimised script examples
Taken from 20/11/15 version of deployable lightning
-
Update deployment to be TBD 86d1358256
-
NicolasDorier commented at 5:46 AM on November 26, 2015: contributor
ACK.
I would replace "Otherwise, script execution will continue as if a NOP had been executed." with "OP_CSV has no effect on the stack". But not worth complaining too much about if I am the only one to think so.
- luke-jr referenced this in commit dd208025cd on Nov 28, 2015
- luke-jr merged this on Nov 28, 2015
- luke-jr closed this on Nov 28, 2015
- luke-jr added the label Proposed BIP modification on Nov 28, 2015
