BIP142 - Typos and grammar #291

pull JornC wants to merge 2 commits into bitcoin:master from JornC:segwit-address changing 1 files +13 −13

JornC commented at 4:29 PM on January 20, 2016: contributor

No description provided.
Fix little typo in p2wpkh address creation e9f9be266f
in bip-0142.mediawiki:None in dda3ac9a04 outdated
```
 125 | @@ -126,7 +126,7 @@ when encoded as a P2PKH template, would become:
 126 |    
 127 |      DUP HASH160 <010966776006953D5567439E5E39F86A0D273BEE> EQUALVERIFY CHECKSIG
 128 |  
 129 | -And the corresponding version 1 Bitcoin address is
 130 | +With the corresponding version 1 Bitcoin address being:
```
JornC commented at 4:31 PM on January 20, 2016:

Technically this is version 0 - not sure what the common nomenclature is here.

jl2012 commented at 7:05 PM on January 20, 2016:

It is called version 1 address on the Bitcoin wiki: https://en.bitcoin.it/wiki/Technical_background_of_version_1_Bitcoin_addresses

in bip-0142.mediawiki:None in dda3ac9a04 outdated

 133 | @@ -134,7 +134,7 @@ When the same public key is encoded as P2WPKH, the scriptPubKey becomes:
 134 |    
 135 |      OP_0 <010966776006953D5567439E5E39F86A0D273BEE>
 136 |  
 137 | -Using 0x06 as witness version, followed 0x00 as witness version, and a 0x00 padding, the equivalent P2WPKH address is:
 138 | +Using 0x06 as witness version, followed by 0x00 as witness version, and a 0x00 padding, the equivalent P2WPKH address is:

jonasschnelli commented at 4:36 PM on January 20, 2016:

You might want to include #290 here. It should be Using 0x06 as address version, followed by 0x00 as witness program version[...]

JornC commented at 4:43 PM on January 20, 2016:

Rebased

JornC force-pushed on Jan 20, 2016
JornC force-pushed on Jan 20, 2016
Typos and grammar 4866fcd392
JornC force-pushed on Jan 20, 2016
jl2012 commented at 7:06 PM on January 20, 2016: contributor

ACK and thanks!
jl2012 cross-referenced this on Jan 20, 2016 from issue Fix little typo in p2wpkh address creation by jonasschnelli
harding commented at 2:51 AM on January 21, 2016: contributor

LGTM.
luke-jr referenced this in commit 2010cf4979 on Jan 22, 2016
luke-jr merged this on Jan 22, 2016
luke-jr closed this on Jan 22, 2016
JornC deleted the branch on Jan 22, 2016

Contributors

Linked (view graph)

#290 Fix little typo in p2wpkh address creation