Also formats the list for readability
Add BIP32 bitcoinjs implementation #310
pull dcousens wants to merge 5 commits into bitcoin:master from dcousens:patch-4 changing 1 files +25 −14-
dcousens commented at 12:25 AM on January 29, 2016: contributor
-
3e0688e12f
Add bitcoinjs reference implementation
Also formats the list for readability
-
fix formatting, mediawiki, not markdown 58374aa7a3
- dcousens renamed this:
Add bitcoinjs reference implementation
Add BIP32 bitcoinjs reference implementation
on Jan 29, 2016 - dcousens renamed this:
Add BIP32 bitcoinjs reference implementation
Add BIP32 bitcoinjs implementation
on Jan 29, 2016 - luke-jr added the label Proposed BIP modification on Jan 29, 2016
- dcousens cross-referenced this on Feb 23, 2016 from issue BIP 32: add BitcoinJS implementation and blockchain.info usage by Sjors
-
681c160239
BIP 32: add BitcoinJS implementation and blockchain.info usage
Closes #338
-
BIP 32: indent list of Javascript implementation(s) f89ee24fe4
-
5643a7e301
Merge pull request #1 from Sjors/patch-5
BIP 32: add BitcoinJS implementation and blockchain.info usage
-
-
sipa commented at 12:09 AM on July 16, 2016: member
Per https://bitcoincore.org/en/meetings/2016/05/12/ please link to actual implementation code for BIP32, and not just applications that support it.
- sipa cross-referenced this on Jul 16, 2016 from issue Update the implementations section of BIP0032. by jgeewax
- luke-jr closed this on Jul 16, 2016
-
dcousens commented at 1:23 AM on July 16, 2016: contributor
@sipa not sure what you mean? The link added was implementation code for BIP32?
This was the link added: https://github.com/bitcoinjs/bitcoinjs-lib/blob/v2.1.4/src/hdnode.js Perhaps I'll rebase and isolate the formatting commit from the addition.
Jcorgan proposes to link to an URL and commit hash, to make sure the linked code reflects the implementation.
Is the commit hash preferred over the tagged version used above? If so, I'll change it.
-
afk11 commented at 2:23 PM on July 16, 2016: contributor
I haven't seen commit hashes included much before, just a link to the implementation's file or repo.
Re sipa's comment, probably refers to mentioning blockchain.info's use of the bitcoin-js implementation; that information is not typically included in BIP documents. https://github.com/bitcoin/bips/pull/310/commits/681c160239fcd7b9cdfb3dc391a39d78b9029529
There is also another PR (#293) which reformats the BIP32 implementation list, perhaps coordinate so there's only one large update?
-
dcousens commented at 4:42 AM on July 17, 2016: contributor
Re sipa's comment, probably refers to mentioning blockchain.info's use of the bitcoin-js implementation; that information is not typically included in BIP documents. 681c160
Right! I totally forgot that those commits were included into this. I'll re-submit a new PR that performs the implementation reference.
If #293 is just a formatting PR, perfect. Otherwise, I'll submit that independently.
- dcousens deleted the branch on Jul 17, 2016
- luke-jr referenced this in commit 130bc5da2c on Jan 20, 2018
- luke-jr referenced this in commit a630180d19 on Jan 20, 2018
