BIP109: BIP102 variation for a 2mb block size bump #328

pull gavinandresen wants to merge 3 commits into bitcoin:master from gavinandresen:bump2mb changing 2 files +88 −0

gavinandresen commented at 2:18 PM on February 11, 2016: contributor

Thanks to @luke-jr for promptly assigning a BIP number.

This was discussed on the bitcoin-dev mailing list, but that discussion went sideways fairly quickly (as do all discussions about hard forks, it seems). It is implemented in Bitcoin Classic.
BIP102 variation for a 2mb block size bump 6cf4333170
in bip-0109.mediawiki:None in 023bf38fed outdated
```
   0 | @@ -0,0 +1,78 @@
   1 | +<pre>
   2 | +  BIP: 109
   3 | +  Title: Block size increase to 2MB
   4 | +  Author: Gavin Andresen
```
btcdrak commented at 2:22 PM on February 11, 2016:

Missing email address should be in the form name <email@example.com>
gavinandresen commented at 2:23 PM on February 11, 2016: contributor

Fixed the malformed author line. Removed a troll-ish comment that is not appropriate for the BIPs repository.

in bip-0109.mediawiki:None in 6cf4333170 outdated

  73 | +
  74 | +==Implementation==
  75 | +
  76 | +https://github.com/gavinandresen/bitcoin-git/tree/two_mb_bump
  77 | +
  78 | +See also http://gavinandresen.ninja/a-guided-tour-of-the-2mb-fork

btcdrak commented at 2:23 PM on February 11, 2016:

Needs a Copyright section according to BIP1

btcdrak commented at 2:25 PM on February 11, 2016: contributor

@gavinandresen Stop deleting comments you don't like on pull requests. https://archive.is/bP0OG
Add copyright c469bd930b
gavinandresen commented at 2:29 PM on February 11, 2016: contributor

@luke-jr : I think the force-push-update confused the travis syntax tester doo-hickey. Let me know if I need to fix something, or if that script needs to be fixed.
luke-jr commented at 4:01 PM on February 11, 2016: member

@gavinandresen I believe the problem is the README.mediawiki title for the BIP doesn't match the actual BIP Title header.
luke-jr added the label New BIP on Feb 11, 2016
Tweaked BIP 109 title 0e7466abc2
harding commented at 7:22 PM on February 11, 2016: contributor

@btcdrak I agree with @gavinandresen that your comment was not appropriate for the BIPs repository, I don't think he did anything inappropriate by deleting it, and I wouldn't have a problem with him deleting your repost of it in the form of an archive.is link.

This repository exists to provide information to the community about situations that affect multiple implementations. Anyone who usefully contributes to this body of knowledge is to be thanked, not yelled at for something they previously did or did not do.
gavinandresen commented at 8:30 PM on February 11, 2016: contributor

@luke-jr that was exactly the problem. It'd be awesome if the travis failures were a little more user friendly (I'd volunteer to fix, but my Perl is beyond rusty).
luke-jr commented at 12:47 AM on February 12, 2016: member

@gavinandresen The relevant test in this case is the diff'ing. It looks for inconsistencies in README.mediawiki with the Perl-generated table (which is based on the BIP headers).
luke-jr referenced this in commit fe1b3b5b7b on Feb 12, 2016
luke-jr merged this on Feb 12, 2016
luke-jr closed this on Feb 12, 2016

Contributors

Labels