BIP143 clarifying semantics of ACP|SINGLE #372

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:patch-16 changing 1 files +15 −11

jl2012 commented at 5:17 AM on April 20, 2016: contributor

This PR clarifies the semantics change when ANYONECANPAY is used with SINGLE, with other minor clarifications
jl2012 commented at 5:19 AM on April 20, 2016: contributor

@sipa
NicolasDorier commented at 5:59 AM on April 20, 2016: contributor

ACK for me except a nit that might be a english mistake on my part:

"does not commit --to-- the input index"

I would say

"does not commit the input index"
jl2012 force-pushed on Apr 20, 2016
jl2012 commented at 6:14 AM on April 20, 2016: contributor

@NicolasDorier fixed. Thanks
in bip-0143.mediawiki:None in 9509c5dca2 outdated
```
   0 | @@ -1,4 +1,4 @@
   1 | -<pre>
   2 | +<pre>
```
luke-jr commented at 7:23 AM on April 20, 2016:

...

btcdrak commented at 7:59 AM on April 20, 2016:

I dont see it?

jl2012 commented at 3:34 PM on April 20, 2016:

@luke-jr I think there was a hidden character but this PR removes it. Isn't it?

MarcoFalke commented at 3:50 PM on April 20, 2016:

https://en.wikipedia.org/wiki/Byte_order_mark#UTF-8

jl2012 commented at 5:41 PM on April 20, 2016:

@MarcoFalke I think there was a BOM before, not now
luke-jr added the label Proposed BIP modification on Apr 20, 2016
BIP143 clarifying semantics of ACP|SINGLE c1ef3a05e3

in bip-0143.mediawiki:None in 9509c5dca2 outdated

  37 |      10. sighash type of the signature (4-byte little endian)
  38 |  
  39 | -All components in the original algorithm, including the behavior <code>OP_CODESEPERATOR</code>, remains unchanged. The only difference is the way of serialization and the inclusion of amount being spent.
  40 | +Semantics of the original sighash types remain unchanged, except the followings:
  41 | +# The way of serialization is changed;
  42 | +# All sighash types commit the amount being spent by the signed input;

sipa commented at 3:45 PM on April 20, 2016:

commit to the amount being spent

jl2012 commented at 5:42 PM on April 20, 2016:

revised and squashed

jl2012 force-pushed on Apr 20, 2016
luke-jr merged this on Apr 20, 2016
luke-jr closed this on Apr 20, 2016

Contributors

Labels

Proposed BIP modification