BIP143: Explicitly mention the SignatureHash function #374

pull kanzure wants to merge 1 commits into bitcoin:master from kanzure:bip143-signaturehash changing 1 files +1 −1

kanzure commented at 5:54 PM on April 20, 2016: contributor

The purpose of BIP143 is to propose an updated SignatureHash function. However, the only keyword reference in the BIP text is "sighash" buried near the end, meanwhile some of the existing source code floating around does not use the name "transaction digest algorithm". Hopefully over time this will change. On a related note, SignatureHash is a really bizarre name....

BIP143: explicitly mention the SignatureHash function

The purpose of BIP143 is to propose an updated SignatureHash function
but "sighash" only appears near the end buried in the text. By
explicitly mentioning the SignatureHash function, readers can more
readily understand the context of the proposal.

a488367502

jl2012 commented at 5:56 PM on April 20, 2016: contributor

ACK
luke-jr merged this on Apr 20, 2016
luke-jr closed this on Apr 20, 2016
sipa commented at 9:22 PM on April 20, 2016: member

@kanzure Do you mind explaining what's bizarre about SignatureHash? It doesn't really matter, as it's just the name of the function, but I'd like to know what made you say that.
kanzure commented at 10:13 PM on April 20, 2016: contributor

@sipa, it's not a signature and it's not a hash of the signature, couldn't possibly be a hash of the signature because the signature is made once signing the output of the function anyway.
sipa commented at 10:25 PM on April 20, 2016: member

@kanzure It's the hash being signed.

Contributors

kanzure

jl2012

sipa