Update bip-0112.mediawiki #381

pull dooglus wants to merge 1 commits into bitcoin:master from dooglus:patch-3 changing 1 files +1 −1
  1. dooglus commented at 5:20 AM on May 1, 2016: contributor

    CHECKLOCKTIMEVERIFY is absolute (not relative) isn't it?

  2. Update bip-0112.mediawiki
    CHECKLOCKTIMEVERIFY is absolute (not relative) isn't it?
    bffcc0c29a
  3. kanzure commented at 1:54 PM on May 1, 2016: contributor

    ACK bffcc0c29a25e3fcbf92ee15fa6f23fe53a7c469, my understanding is that OP_CHECKSEQUENCEVERIFY is relative (a.k.a OP_RELATIVECHECKLOCKTIMEVERIFY). Another interesting way to verify this is https://github.com/ElementsProject/lightning/blob/f4e94147a7281ec05e078ff9f3e6d65893417bad/bitcoin/script.c#L377

  4. btcdrak commented at 4:15 PM on May 1, 2016: contributor

    This is the second time this has come up so maybe it's worth addressing. That's it's an absolute timelock cannot be misunderstood because that's what the opcode does, but I would prefer to notate it as something like <now + 24h> similar to how it's notated in BIP65.

  5. luke-jr added the label Proposed BIP modification on May 1, 2016
  6. dooglus commented at 10:04 PM on May 1, 2016: contributor

    @btcdrak Using <now + 24h> is clear enough. Using a literal "24h" is simply confusing, especially when the two HTLC commitment examples use different string literals as they currently do:

    With CHECKSEQUENCEVERIFY, a HTLC payable to Alice might look like the following in Alice's commitment transaction: "24h" CHECKLOCKTIMEVERIFY DROP and correspondingly in Bob's commitment transaction: "2015/10/20 10:33" CHECKLOCKTIMEVERIFY

  7. btcdrak commented at 1:57 AM on May 2, 2016: contributor

    @dooglus Please make the change then I can ack it.

  8. dooglus commented at 2:38 AM on May 2, 2016: contributor

    How would you like the change?

    There are currently three examples of CHECKLOCKTIMEVERIFY in the BIP:

        `"2015/12/15" CHECKLOCKTIMEVERIFY DROP`
    
           `"24h" CHECKLOCKTIMEVERIFY DROP`
    
      `"2015/10/20 10:33" CHECKLOCKTIMEVERIFY`
    

    Do you want them all to use a relative time offset? Or just the last two? Or do you want the Alice and Bob commitments, which are pretty much symmetrical, to use different types of offset, one relative and one absolute?

    I'm not understanding your motivation for wanting any of them to be relative to now when the opcode itself uses an absolute time, and so it's hard to know exactly what kind of a change you would be willing to accept.

  9. btcdrak commented at 7:51 PM on May 2, 2016: contributor

    @dooglus Yes you are right. OK as is.

    ACK bffcc0c

  10. btcdrak commented at 8:01 PM on May 10, 2016: contributor

    ping @luke-jr please can you merge this.

  11. luke-jr merged this on May 10, 2016
  12. luke-jr closed this on May 10, 2016


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me