A BIP in state STARTED that did not reach the threshold would disappear instead of stay in STARTED.
The hex error made me looking for a bug for almost an hour after copy pasting the hex values.
Error in BIP0009 code example #388
pull stevenroose wants to merge 3 commits into bitcoin:master from stevenroose:patch-2 changing 1 files +3 −3-
stevenroose commented at 12:23 PM on May 14, 2016: contributor
-
BIP0009 code syntax fix f71727f1c3
-
Error in BIP0009 code 1a3613622b
-
Less visible error 580db15907
- luke-jr added the label Proposed BIP modification on May 18, 2016
-
luke-jr commented at 7:39 PM on May 18, 2016: member
-
stevenroose commented at 7:46 PM on May 18, 2016: contributor
The only real error is the hex. I thing the added return statement was just forgotten or considered obvious, however it is explicitly added in the fragment above.
-
sipa commented at 7:51 PM on May 18, 2016: member
ACK
- luke-jr merged this on May 18, 2016
- luke-jr closed this on May 18, 2016
Contributors