Define the retarget period
Define retarget period in BIP9 #390
pull Christewart wants to merge 1 commits into bitcoin:master from Christewart:patch-1 changing 1 files +1 −1-
Christewart commented at 2:21 PM on May 19, 2016: none
- Christewart renamed this:
Update bip-0009.mediawiki
Define retarget period in BIP9
on May 19, 2016 - luke-jr added the label Proposed BIP modification on May 21, 2016
-
luke-jr commented at 7:31 AM on May 21, 2016: member
-
sipa commented at 7:37 AM on May 21, 2016: member
"Currently" seems confusing, as the retarget interval is not something that is easy to change. The interval for BIP9 however IS easy to change.
-
Christewart commented at 3:44 PM on May 21, 2016: none
@sipa What do you mean by the 'interval for BIP9'? Is this the amount of blocks that is needed for a proposed soft fork to go from 'DEFINED' to 'ACTIVE'/'FAILED'?
-
sipa commented at 3:51 PM on May 21, 2016: member
The sampling interval. BIP9 specifies to sample at every retarget, which is every 2016 blocks. However, the sampling interval van be changes to something else, the retarget interval can't. So saying that the retarget interval is 'currently' 2016 is confusing.
-
Christewart commented at 3:54 PM on May 21, 2016: none
Interesting, perhaps we should add language around that in the BIP as well. It doesn't seem like that is said explicitly in the BIP right now. I'll write something up wrt to that later. I'll also remove the word 'currently'.
-
Christewart commented at 1:02 PM on May 23, 2016: none
Never mind, i'm not going to add language around the sampling interval. Assuming everyone is ok with my last change I'm not going to add any more commits.
-
rustyrussell commented at 9:37 PM on May 23, 2016: contributor
Luke-Jr notifications@github.com writes:
Surprised retarget period needs definition. If you want to, I'd say just change:
These are tallied each retarget period.
To:
These are tallied each retarget period (2016 blocks).
Cheers, Rusty.
-
sipa commented at 1:15 PM on May 31, 2016: member
@rustyrussell's suggestion looks fine
-
1e186f9b4f
Update bip-0009.mediawiki
Define the retarget period Update bip-0009.mediawiki Update bip-0009.mediawiki
- Christewart force-pushed on Jun 14, 2016
-
Christewart commented at 12:24 AM on June 14, 2016: none
@luke-jr @sipa i've changed it to what @rustyrussell suggested and rebased. Should be good to merge
-
petertodd commented at 5:10 PM on June 15, 2016: contributor
Weak NACK - this isn't really detailed enough to be an implementable spec by itself, as there's other details about retarget periods that you'd need to know to actually implement this. So with that in mind I'd rather just keep calling it a "retarget period" in the spirit of "the code is the spec; bips just describe intent"
- luke-jr closed this on Jul 15, 2016
Contributors