This message (filterclear) isn't included in the reasons for moving bloom services into a opt-out service.
Also, filterclear is a useful way for nodes to start with TX relay off and to request TX relay later. (e.g. during IBD).
Discussed in https://github.com/bitcoin/bitcoin/pull/8709
This message isn't included in the reasosn for moving bloom services into a opt-out service.
Also, filterclear is a useful way for nodes to start with TX relay off and to request TX relay later. (e.g. during IBD).
I think it's too late to change this, though...?
The context is https://github.com/bitcoin/bitcoin/pull/8709 I support the idea, but the text needs to note that some versiond do ban for filterclear, but it is very strongly recommended (maybe MUST) that new versions do not do so.
Given the low consequences for connecting to a peer without this change - getting disconnected - I think it's reasonable to change this behavior and just phase it in over time. Also as @pstratem notes, reconnecting after IBD is sufficient for now: https://github.com/bitcoin/bitcoin/pull/8709#issuecomment-248200651 (which retry logic in your implementation may very well do anyway!)
So is that an ack, or does it need changes? (What's the status here?)
This needs some text to note that some nodes on the network will additionally disconnect for filterclear, but new implementations MUST NOT do so.
I think it's too late to change this, though...?
i think it is now!