Clarifies some language (eg replaces "the relative lock-time type is not the same" with "the transaction input relative lock-time type (1 << 22) is not the same as the top stack item lock-time type (1 << 22)") and fixes a typo "the the"
Clarify BIP 112 language and fix typo #452
pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:bip_112_clarification changing 1 files +3 −4-
jnewbery commented at 4:11 PM on September 30, 2016: member
-
luke-jr commented at 12:16 AM on October 1, 2016: member
- luke-jr added the label Proposed BIP modification on Oct 1, 2016
-
jl2012 commented at 7:15 PM on October 15, 2016: contributor
there is no transaction input version
-
maaku commented at 8:03 PM on October 15, 2016: contributor
Off-topic, but the nVersion field is stored in the UTXO database, so "transaction input version" could be interpreted to mean something. Off-topic because that's not what is being checked by the code:
It is checking if the spending transaction, the one which contains the input, has an nVersion greater than 2.
Upon further review lines 30 and 31 probably deserve to be clarified, but I'm not sure the new text is better. Maybe @jnewbery can explain the confusion he had and was trying to correct?
The changes to lines 35 and 36 are deserving and look good.
-
jnewbery commented at 5:03 PM on October 17, 2016: member
@jl2012 , @maaku - thanks for your comments.
- line 28 - yes you're correct, there's no such thing as transaction input version. Sorry, probably overzealous search/replace on my part.
- line 30 - used to say
the relative lock-time type is not the same, which begs the question: Not the same as what? It's not specified. I think it's clearer to say on one line which two values are being compared. - line 31 - again, I think it's best to clearly specify which two values are being compared. The old text said 'transaction sequence' instead of 'transaction input sequence', and the
(when masked according to the BIP68)is ambiguous language (the masking could apply to the sequence number, the top stack item, or both.
-
-
-
-
Clarify BIP 112 language and fix typo 1e1f7da628
- jnewbery force-pushed on Aug 14, 2017
-
-
jnewbery commented at 9:35 PM on August 24, 2017: member
Closing. BIP process seems broken if typo fixes can't be merged.
- jnewbery closed this on Aug 24, 2017
- jnewbery cross-referenced this on May 17, 2018 from issue BIP 112: fix typo by fedsten
Linked (view graph)