Update bip-0037.mediawiki #5

pull benjiqq wants to merge 1 commits into bitcoin:master from benjiqq:patch-1 changing 1 files +2 −2
  1. benjiqq commented at 7:18 pm on December 28, 2013: none
    fix typo and link
  2. Update bip-0037.mediawiki
    fix typo and link
    710bc32666
  3. gmaxwell commented at 0:33 am on December 29, 2013: contributor
    I believe “they are sent” is the correct and intended language here.
  4. sipa commented at 0:34 am on December 29, 2013: member
    agree with @gmaxwell
  5. sipa commented at 0:35 am on December 29, 2013: member
    Meta comment: now that BIPs are on github, under what rules can modifications be made? I believe they should require consent from at least the original author.
  6. gmaxwell commented at 0:39 am on December 29, 2013: contributor
    “require” is perhaps too strong— what happens if the author is absentee? And if the change is very obviously correct, pure copyediting, etc?
  7. benjiqq commented at 9:07 am on December 29, 2013: none
    Ok, my mistake. “data they receive” or “data they are sent to” might make it a bit clearer.
  8. gmaxwell commented at 9:11 am on December 29, 2013: contributor
    “Benjyc, did Alice enjoy the package she was sent?”
  9. josephNLD commented at 11:04 am on December 30, 2013: none

    Good examples for the grammar.
    Nouns may still be better than pronouns for precision where possible.

    Whether it reduces what is received or what is sent is a non-trivial function of where/how the bloom filter is applied and is significant for network billing and storage concerns. “reduce the amount of transaction data they are sent” - conveys filtered at remote peer, prior to sending (appropriately).

    “reduce the amount of transaction data sent to them by their peers” - slightly more precise as the BIP doesn’t filter what is sent to others.

    tl;dr it is fine as it is.

  10. benjiqq closed this on Dec 30, 2013

  11. luke-jr referenced this in commit 7cecfacdf5 on Jan 8, 2016
  12. luke-jr referenced this in commit e4a7582c98 on Mar 17, 2016
  13. justusranvier referenced this in commit f048678277 on Jul 11, 2016
  14. luke-jr referenced this in commit 9b7a2922b1 on Jun 6, 2017
  15. real-or-random referenced this in commit d95029ebe4 on Sep 28, 2018
  16. luke-jr referenced this in commit 3e68fe48dc on Aug 30, 2021
  17. ariard cross-referenced this on Mar 8, 2023 from issue Add OP_VAULT (BIP 345) by jamesob

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 15:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me