fix typo and link
Update bip-0037.mediawiki #5
pull benjiqq wants to merge 1 commits into bitcoin:master from benjiqq:patch-1 changing 1 files +2 −2-
benjiqq commented at 7:18 PM on December 28, 2013: none
-
710bc32666
Update bip-0037.mediawiki
fix typo and link
-
gmaxwell commented at 12:33 AM on December 29, 2013: contributor
I believe "they are sent" is the correct and intended language here.
-
sipa commented at 12:35 AM on December 29, 2013: member
Meta comment: now that BIPs are on github, under what rules can modifications be made? I believe they should require consent from at least the original author.
-
gmaxwell commented at 12:39 AM on December 29, 2013: contributor
"require" is perhaps too strong— what happens if the author is absentee? And if the change is very obviously correct, pure copyediting, etc?
-
benjiqq commented at 9:07 AM on December 29, 2013: none
Ok, my mistake. "data they receive" or "data they are sent to" might make it a bit clearer.
-
gmaxwell commented at 9:11 AM on December 29, 2013: contributor
"Benjyc, did Alice enjoy the package she was sent?"
-
josephNLD commented at 11:04 AM on December 30, 2013: none
Good examples for the grammar.
Nouns may still be better than pronouns for precision where possible.Whether it reduces what is received or what is sent is a non-trivial function of where/how the bloom filter is applied and is significant for network billing and storage concerns. "reduce the amount of transaction data they are sent" - conveys filtered at remote peer, prior to sending (appropriately).
"reduce the amount of transaction data sent to them by their peers" - slightly more precise as the BIP doesn't filter what is sent to others.
tl;dr it is fine as it is.
- benjiqq closed this on Dec 30, 2013
- luke-jr referenced this in commit 7cecfacdf5 on Jan 8, 2016
- luke-jr referenced this in commit e4a7582c98 on Mar 17, 2016
- justusranvier referenced this in commit f048678277 on Jul 11, 2016
- luke-jr referenced this in commit 9b7a2922b1 on Jun 6, 2017
- real-or-random referenced this in commit d95029ebe4 on Sep 28, 2018
- luke-jr referenced this in commit 3e68fe48dc on Aug 30, 2021
- ariard cross-referenced this on Mar 8, 2023 from issue Add OP_VAULT (BIP 345) by jamesob