Simplify UASF Activation Logic, and update specification. #515

pull da2ce7 wants to merge 1 commits into bitcoin:master from da2ce7:bip148 changing 1 files +11 −3

da2ce7 commented at 9:53 AM on April 10, 2017: contributor

This Pull Request Enforces That SegWit is activated, even if the hash-rate is very very slow.
Simplify UASF Activation Logic, and update specification. e0a30bbc6b
da2ce7 cross-referenced this on Apr 10, 2017 from issue BIP148: UASF-Segwit by sneurlax
luke-jr added the label Proposed BIP modification on Apr 10, 2017
shaolinfry commented at 10:00 AM on April 10, 2017: contributor

I disagree with this change.
luke-jr commented at 10:01 AM on April 10, 2017: member

It's unclear to me how BIP 141 nodes will react to a post-timeout activation.
da2ce7 commented at 10:02 AM on April 10, 2017: contributor

@luke-jr from my understanding they will not enforce SegWit.
shaolinfry commented at 10:04 AM on April 10, 2017: contributor

You cannot change the activation parameters of another BIP mid deployment. BIP148 is it's own soft fork.
mkwia commented at 10:05 AM on April 10, 2017: none

I don't think this is a good PR.
luke-jr commented at 10:08 AM on April 10, 2017: member

@da2ce7 but they may reject blocks as invalid because they fetch the full block, and don't consider witness data valid in it...
luke-jr commented at 10:09 AM on April 10, 2017: member

Closing due to NACK from @shaolinfry
luke-jr closed this on Apr 10, 2017

in bip-0148.mediawiki:29 in e0a30bbc6b

  23 | @@ -24,18 +24,27 @@ This document specifies a BIP16 like soft fork flag day activation of the segreg
  24 |  
  25 |  Segwit increases the blocksize, fixes transaction malleability, and makes scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].
  26 |  
  27 | -It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP will cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.
  28 | +It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP may cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.
  29 | +
  30 | +This BIP mandatory enforces SegWit within one full 2016 block retagat intivals after August 1st 2017.

dooglus commented at 6:22 PM on April 10, 2017:

"retagat intivals"?

in bip-0148.mediawiki:46 in e0a30bbc6b

  43 |  === Reference implementation ===
  44 |  
  45 | +In chainparams.cpp: Set BIP 9 flag to never time-out.
  46 | +
  47 | +- consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 1493596800; // May 1st 2017
  48 | ++ consensus.vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout = 999999999999ULL; // Never (BIP 148)

dooglus commented at 6:25 PM on April 10, 2017:

What happens to Core nodes if UASF nodes activate SegWit after November 2017? Core nodes will only recognize SegWit lock-in until November 2017.

Contributors

Labels

Proposed BIP modification