Explain that BIP148 may not lead to the activation of SegWit. #516

da2ce7 commented at 3:28 PM on April 10, 2017: contributor

I found this quite non obvious; so I have made a pull request to fix the wording.

Yes, my last pull request was ill-conceived, thank-you as-always for the review.

luke-jr added the label Proposed BIP modification on Apr 10, 2017

luke-jr commented at 11:10 PM on April 10, 2017: member

Suggest moving this outside Specification, and explaining that segwit can be re-proposed as a normal UASF in this circumstances.

htoohtetaung approved

in bip-0148.mediawiki:27 in 5fd6899b26 outdated

  23 | @@ -24,7 +24,9 @@ This document specifies a BIP16 like soft fork flag day activation of the segreg
  24 |  
  25 |  Segwit increases the blocksize, fixes transaction malleability, and makes scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].
  26 |  
  27 | -It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP will cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.
  28 | +It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP may cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.

jonathancross commented at 1:29 PM on April 24, 2017:

"before the end of midnight" can simply be written as "before midnight" (I know you didn't write this part, but would be nice to update if making changes to this line)

in bip-0148.mediawiki:29 in 5fd6899b26 outdated

  23 | @@ -24,7 +24,9 @@ This document specifies a BIP16 like soft fork flag day activation of the segreg
  24 |  
  25 |  Segwit increases the blocksize, fixes transaction malleability, and makes scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].
  26 |  
  27 | -It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP will cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.
  28 | +It is hoped that miners will respond to this BIP by activating segwit early, before this BIP takes effect. Otherwise this BIP may cause the mandatory activation of the existing segwit deployment before the end of midnight November 15th 2017.
  29 | +
  30 | +In the cases that the hashrate drops to below 14% over 3.5 months sustained, it is possible that SegWit is not locked-in before November 15th 2017.

jonathancross commented at 1:35 PM on April 24, 2017:

If the hashrate drops below 14% for a sustained 3.5 month period, it is possible that segwit will not be locked-in before November 15th 2017.

jonathancross changes_requested

jonathancross commented at 1:40 PM on April 24, 2017: contributor

A couple small wording suggestions...

da2ce7 force-pushed on Apr 28, 2017

Explain that this BIP may not lead to the activation of SegWit. b30048d850

da2ce7 force-pushed on Apr 28, 2017

da2ce7 commented at 12:06 PM on April 28, 2017: contributor

@jonathancross, thank-you for your wording suggestions, I have adopted them in this pull request.

luke-jr renamed this:
~~Explain that this BIP may not lead to the activation of SegWit.~~
Explain that BIP148 may not lead to the activation of SegWit.
on Jul 26, 2017

murchandamus assigned murchandamus on Apr 23, 2024

murchandamus assigned sipa on Apr 23, 2024

murchandamus unassigned murchandamus on Apr 23, 2024

murchandamus unassigned sipa on Apr 23, 2024

murchandamus commented at 6:56 PM on April 23, 2024: contributor

While the changes seem reasonable to me, it looks like the author has not shown interest in almost 7 years to add this amendment to their BIP. As such, I’m closing this PR now, but please feel free to ask to reopen it, if you would like to continue pursuing a merge.

murchandamus closed this on Apr 23, 2024