Update bip-0148.mediawiki #517

pull negatratoron wants to merge 1 commits into bitcoin:master from negatratoron:patch-1 changing 1 files +1 −1

negatratoron commented at 11:43 PM on April 10, 2017: none

There is no need to increase the block size.
Update bip-0148.mediawiki e791f44e1d
luke-jr added the label Proposed BIP modification on Apr 11, 2017
luke-jr commented at 8:30 AM on April 11, 2017: member

@shaolinfry @jeffersoncarpenter Note this doesn't say it's needed, just that Segwit does it - which is true.

in bip-0148.mediawiki:25 in e791f44e1d

  21 | @@ -22,7 +22,7 @@ This document specifies a BIP16 like soft fork flag day activation of the segreg
  22 |  
  23 |  ==Motivation==
  24 |  
  25 | -Segwit increases the blocksize, fixes transaction malleability, and makes scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].
  26 | +Segwit fixes transaction malleability, and makes scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].

MickSHunt commented at 1:51 AM on April 12, 2017:

Segwit disarms transaction malleability only for those opting to use Segwit keypairs, allowing them to make scripting easier to upgrade as well as bringing many other [https://bitcoincore.org/en/2016/01/26/segwit-benefits/ benefits].

MickSHunt changes_requested
MickSHunt commented at 2:05 AM on April 12, 2017: none

Segwit does not make malleability impossible. it only affects users that opt-in to use Segwit keypairs for their funds
shaolinfry commented at 3:58 AM on April 12, 2017: contributor

Segwit is a blocksize increase.
MickSHunt commented at 10:12 AM on April 12, 2017: none

shaolinfry. the fixes are only for those using segwit keys. where as everyone else is still stuck in the 1mb base block and still able to malleate/quadratic spam and do the other things. many people wrongly think that just activating segwit fixes all the stuff instantly for everyone. it needs clarification that its not the activation of the block structure that matters, but who is using segwit keys
afk11 commented at 12:55 PM on April 12, 2017: contributor

@MickSHunt BIP148 is an activation mechanism, it's not necessary to detail segwit's semantics here.
MickSHunt commented at 1:35 PM on April 12, 2017: none

but for people to know what they are flagging for. its best they know what they will get if it does activate
shaolinfry commented at 6:30 PM on April 12, 2017: contributor

@MickSHunt Segwit is a blocksize increase. @luke-jr please close this pull request.
negatratoron commented at 9:48 PM on April 12, 2017: none

Okay, sounds good. This is just how segwit is defined.
negatratoron closed this on Apr 12, 2017

Contributors

Labels

Proposed BIP modification