BIP66 comment typo fix #528

pull comboy wants to merge 1 commits into bitcoin:master from comboy:bip66-typo-fix changing 1 files +1 −1
  1. comboy commented at 8:06 PM on April 30, 2017: contributor

    I've been triple checking it, since I'm surprised it would stay there for so long unnoticed, but I've become pretty convinced there's a typo in that comment.

    (sorry about the separate PR, didn't notice it when I was fixing the dead link)

  2. BIP66 comment typo fix 1341c89081
  3. luke-jr requested review from sipa on Apr 30, 2017
  4. luke-jr added the label Proposed BIP modification on Apr 30, 2017
  5. sipa commented at 11:33 PM on April 30, 2017: member

    @comboy No, this is incorrect. The S element has a length descriptor, which follows the R element. This line is checking that that length descriptor is not outside the data array.

  6. luke-jr closed this on Apr 30, 2017

  7. comboy commented at 11:51 PM on April 30, 2017: contributor

    Ah, not the length of the S element itself but the length byte, right, sorry about that.

  8. comboy deleted the branch on Apr 30, 2017
Contributors


sipa


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me