Update BIP173: new reference impls + tests fix #565

pull sipa wants to merge 3 commits into bitcoin:master from sipa:bip-witaddr changing 1 files +11 −3

sipa commented at 10:00 PM on August 2, 2017: member

No description provided.
Add more reference implementations 192cfbbacd
Fix incorrect tests for OP_n in v1+ witnesses 9b1e7dc8f5
sipa cross-referenced this on Aug 2, 2017 from issue Fix tests for non-v0 witnesses by sipa
gmaxwell commented at 2:03 AM on August 3, 2017: contributor

ACK but at the bottom of decoding add:

Implementations should take special care when converting the address to a ScriptPubkey: In Bitcoin script while 0 is encoded as 0x00 the numbers 1 through 16 are encoded as 0x51 though 0x60 (81 to 96 in decimal). If a bech32 address is converted to an incorrect scrippubkey the result will likely be either unspendable or insecure, either of which is undesirable.
clarkmoody commented at 2:23 AM on August 3, 2017: contributor

I agree with @gmaxwell that additional explanation is in order. Thankfully OP_1 through OP_16 have contiguous values ;-)
sipa commented at 7:16 PM on August 3, 2017: member

@gmaxwell Rewrote that a bit, and added it.
Elaborate on the encoding of witness versions 59391f1862
sipa force-pushed on Aug 4, 2017
gmaxwell approved
gmaxwell commented at 6:31 AM on August 4, 2017: contributor

ACK
sipa referenced this in commit 5bdd648417 on Aug 4, 2017
sipa commented at 5:04 AM on August 7, 2017: member

@luke-jr Ping?
luke-jr merged this on Aug 7, 2017
luke-jr closed this on Aug 7, 2017

Contributors