Remove second service bit from NODE_NETWORK_LIMITED/BIP159 #592

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:node_network_limited changing 2 files +11 −13

jonasschnelli commented at 2:08 AM on September 23, 2017: contributor

This removes the split between NODE_NETWORK_LOW|HIGH and reduced the specification to a single signalling bit (bit 10) NODE_NETWORK_LIMITED with a min height of 288 blocks.

The implementation has already been updated: https://github.com/bitcoin/bitcoin/pull/10387

in bip-0159.mediawiki:24 in c4a2aee7ee outdated

  21 |  Pruned peers can offer the same services as traditional peer except of serving all historical blocks.
  22 |  Bitcoin right now only offers the NODE_NETWORK service bit which indicates that a peer can serve
  23 |  all historical blocks.
  24 |  # Pruned peers can relay blocks, headers, transactions, addresses and can serve a limited number of historical blocks, thus they should have a way how to announce their service(s)
  25 | -# Peers no longer in initial block download should consider connection some of its outbound connections to pruned peers to allow other peers to bootstrap from non-pruned peers
  26 | +# Peers no longer in initial block download should consider connect some of its outbound connections to pruned peers to allow other peers to bootstrap from non-pruned peers

luke-jr commented at 2:33 AM on September 23, 2017:

connecting*

jonasschnelli commented at 2:35 AM on September 23, 2017:

Thanks! Fixed.

jonasschnelli force-pushed on Sep 23, 2017
jonasschnelli force-pushed on Sep 23, 2017
Remove second service bit from NODE_NETWORK_LIMITED/BIP159 8b971ea4de
jonasschnelli force-pushed on Sep 23, 2017
jonasschnelli commented at 3:24 PM on September 23, 2017: contributor

Fixed also the README file.
luke-jr merged this on Sep 23, 2017
luke-jr closed this on Sep 23, 2017

Contributors

jonasschnelli

luke-jr