BIP 175 Improvements #593

pull jonathancross wants to merge 1 commits into bitcoin:master from jonathancross:bip-175 changing 1 files +17 −14

jonathancross commented at 3:22 AM on September 23, 2017: contributor
- Standardizing spelling of "payer".
- In examples:
  
  Added headings
  
  Separated "document 1:" label from the contents which are actually hashed (eg "baz").
- Misc spelling mistakes. @omarshibli
BIP 175 Typo fixes, etc d8d5a0d8a3
luke-jr added the label Proposed BIP modification on Sep 23, 2017
omarshibli commented at 5:41 AM on September 23, 2017: contributor

looks good, thanks a lot. just one small comment regarding the subheadings in Examples section, imho, if you want to make these subheadings, I would consider removing the colon at the end, I don't think colon at the end of string in the contents section would be an aesthetic thing. <img width="407" alt="examples section screenshot" src="https://user-images.githubusercontent.com/1773485/30770485-b5019d42-a03a-11e7-83da-3c26161b31d3.png"> Thoughts?
omarshibli commented at 11:49 AM on October 2, 2017: contributor

ACK I will submit a separate PR for subheading style. @luke-jr
luke-jr merged this on Oct 2, 2017
luke-jr closed this on Oct 2, 2017
jonathancross deleted the branch on Oct 8, 2017

Contributors

Labels