Validate a payment request is still valid prior to payment #60

pull aalness wants to merge 1 commits into bitcoin:master from aalness:aalness_bip70 changing 1 files +1 −0

aalness commented at 10:30 PM on May 2, 2014: contributor

Currently there exists the potential for a user to load a payment request into their wallet which is valid at that time but its expiration lapses prior to the user authorizing the payment. This could lead to an unnecessary customer service interaction.
aalness cross-referenced this on May 2, 2014 from issue [Qt] Payment request expiration bug fix by aalness
schildbach commented at 8:04 AM on May 3, 2014: contributor

I think the last expiration time check should take place immediately before broadcasting the signed tx or exposing it via a payment message, whichever comes first. The reason is transaction creation and signing can take from several seconds up to hours/days (if multiple persons need to sign).

Validate a payment request is still valid prior to payment

Currently there exists the potential for a user to load a payment request into
their wallet which is valid at that time but its expiration lapses prior to
the user authorizing the payment. This could lead to an unnecessary customer
service interaction.

18bb72aa27

aalness commented at 1:11 AM on May 6, 2014: contributor

@schildbach good point. I updated my change to move the check immediately before the broadcast step. Seem reasonable?
gavinandresen commented at 12:17 PM on May 7, 2014: contributor

This pull request is OK with me.

I don't really care; the PaymentRequest could be considered expired by the merchant because the the merchant and customers machines disagree about the time, so there will always be annoying edge cases.
aalness commented at 5:03 PM on May 7, 2014: contributor

Thanks for the review and agreed. I think there will always be edge cases out of the wallet's control but if it can do anything to avoid mis-payment I think it should try.
gavinandresen referenced this in commit 6711d299b3 on May 20, 2014
gavinandresen merged this on May 20, 2014
gavinandresen closed this on May 20, 2014
luke-jr referenced this in commit 6e99d24619 on Jun 6, 2017
real-or-random referenced this in commit 85febc4d49 on Feb 23, 2023

Contributors

aalness

schildbach

gavinandresen