Added additional parentesis for clear understanding of the equation on this row. I am doing this proposition because I was stuck on this part for quite some time untill I understood that I furst need to add and then do the modular devision. I think that this way, the order of operations is more clear.
BIP 32: Private key derivation operation order fix #615
pull gspasov wants to merge 1 commits into bitcoin:master from gspasov:patch-1 changing 1 files +1 −1-
gspasov commented at 10:53 AM on December 11, 2017: none
-
ad866d2dca
Private key derivation operation order fix
Added additional parentesis for clear understanding of the equation on this row. I am doing this proposition because I was stuck on this part for quite some time untill I understood that I furst need to add and then do the modular devision. I think that this way, the order of operations is more clear.
-
- luke-jr requested review from sipa on Dec 11, 2017
- luke-jr added the label Proposed BIP modification on Dec 11, 2017
- luke-jr renamed this:
Private key derivation operation order fix
BIP 32: Private key derivation operation order fix
on Dec 11, 2017 -
sipa commented at 6:11 PM on December 11, 2017: member
Unsure. The "(mod n)" at the end just means the entire operation is done modulo n. It's not an operation.
-
dcousens commented at 11:12 PM on December 11, 2017: contributor
We actually had this come up recently in https://github.com/bitcoinjs/bitcoinjs-lib/issues/929#issuecomment-345909669
-
gspasov commented at 6:50 AM on December 12, 2017: none
@sipa Well I didn't know that. And this made me stay on this problem some days until I understood that I wasn't doing the operations in the correct order. I'm sure I wasn't the only one that got confused there and I won't be the last one. After I figured it out I asked some people what did they think this operation is done and they had the same first thought as I did. So either we are all blind or this isn't written the best way possible.
-
meshcollider commented at 12:31 PM on December 13, 2017: contributor
The (mod n) at the end is standard in maths, I don't think changing it here improves clarity
- luke-jr closed this on May 20, 2018
