bip159: Clarify that there is only one threshold #617

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1712-bip159rework changing 1 files +5 −7
  1. MarcoFalke commented at 6:56 PM on December 19, 2017: member

    @jonasschnelli

    Changes:

    • The last section mentions "thresholds", while only a single threshold of 244 is specified in the bip. Clarify by changing to "threshold"
    • Remove internal Bitcoin Core implementation detail. This is not relevant for a bip.
    • Remove word "additional" when referring to safety buffer, since the safety buffer is the only buffer and not an additional one.
    • Remove empty section "references"
    • Add missing link to signaling implementation.
  2. bip159: Clarify that there is only one threshold fa810b3bff
  3. jonasschnelli commented at 6:57 PM on December 19, 2017: contributor

    Thanks! ACK f455a24da7b098d390b6405ae19826d0c5684c3e

  4. bip159: Add missing link to implementation fa9a4f307e
  5. MarcoFalke commented at 7:01 PM on December 19, 2017: member

    Added a link to the signaling implementation after your review.

  6. jonasschnelli commented at 7:06 PM on December 19, 2017: contributor

    Also ACK fa9a4f307eb241b69f04681c3da35b7f69cf9fd5

  7. luke-jr merged this on Dec 19, 2017
  8. luke-jr closed this on Dec 19, 2017

  9. MarcoFalke deleted the branch on Dec 19, 2017

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 12:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me