Run flake8 tests on all new code submissions #619

pull cclauss wants to merge 1 commits into bitcoin:master from cclauss:patch-1 changing 1 files +12 −3

cclauss commented at 7:14 AM on December 25, 2017: none
flake8 testing of https://github.com/bitcoin/bips on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
```
./bip-0069/bip-0069_examples.py:52:9: F821 undefined name 'bytearray_cmp'
	return bytearray_cmp(output_tuple1[1], output_tuple2[1])
               ^
1     F821 undefined name 'bytearray_cmp'
```

Run flake8 tests on all new code submissions

flake8 testing of https://github.com/bitcoin/bips on Python 3.6.3

$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./bip-0069/bip-0069_examples.py:52:9: F821 undefined name 'bytearray_cmp'
	return bytearray_cmp(output_tuple1[1], output_tuple2[1])
               ^
1     F821 undefined name 'bytearray_cmp'
```

b6252a65fa

luke-jr commented at 7:18 AM on December 25, 2017: member

Why? BIPs aren't source code, they're documents...
cclauss commented at 7:20 AM on December 25, 2017: none

Because this repo contains ./bip-0069/bip-0069_examples.py and that file could raise a NameError exception at runtime. How can users verify the validity of implementations when the examples crash?

See: https://travis-ci.org/bitcoin/bips/builds/321281686
promag commented at 10:57 PM on May 23, 2018: member

@luke-jr why not? @cclauss maybe include the fix in a commit (before the current commit)?
cclauss closed this on Sep 22, 2019
cclauss deleted the branch on Sep 22, 2019
cclauss referenced this in commit 618022c465 on Jan 23, 2020
cclauss cross-referenced this on Jan 23, 2020 from issue Undefined name: bytearray_cmp --> bytearr_cmp by cclauss

Contributors

cclauss

luke-jr

promag

Linked (view graph)

#878 Undefined name: bytearray_cmp --> bytearr_cmp