Add brazilian portuguese wordlist to BIP39 #654

pull kuthullu wants to merge 1 commits into bitcoin:master from kuthullu:portuguese_brazilian changing 2 files +2057 −0

kuthullu commented at 2:31 PM on February 28, 2018: contributor

The wordlist consists of 2048 non offensive, manually picked brazilian portuguese words.

Also edited the README with a small note about the work done.
Add brazilian portuguese wordlist 31b89160cb
luke-jr commented at 3:03 AM on April 1, 2018: member

@slush0 @prusnak @voisine @ebfull
luke-jr added the label Proposed BIP modification on Apr 1, 2018
prusnak commented at 11:15 AM on April 2, 2018: contributor

I don't care about this lists. The only list I support is the English one.
guilhermep commented at 7:50 PM on May 3, 2018: none

I think this list should not contain words in common with the other wordlists, following the precedent set by the spanish, italian and french lists and maintaining the possibility to detect the language with just one word.
brenorb commented at 8:20 AM on June 15, 2018: contributor

I suggest changing the word "abdome" and other words which have more than one possible orthography in portuguese.
iancoleman cross-referenced this on Jul 17, 2018 from issue Add Portuguese (Brazil) wordlist by johnnyasantoss
johnnyasantoss commented at 2:40 AM on July 27, 2018: none

Is there any progress with this PR? I agree with @brenorb argument about having words that may cause confusion.
luke-jr commented at 6:16 PM on August 9, 2018: member

One or more of the authors is needed to approve any modifications.
in bip-0039/portuguese_brazilian.txt:13 in 31b89160cb
```
   8 | +absinto

   9 | +absurdo

  10 | +abutre

  11 | +acaso

  12 | +acelga

  13 | +acento
```
brenorb commented at 6:44 PM on August 9, 2018:

I suggest changing words like "abdome" which can be written in more than one form, and words like "acento", which sounds identical to "assento".
in bip-0039/portuguese_brazilian.txt:3 in 31b89160cb
```
   0 | @@ -0,0 +1,2048 @@
   1 | +abacaxi

   2 | +abaixo

   3 | +abdome
```
brenorb commented at 6:45 PM on August 9, 2018:

Has two forms of writing. It might be best to change it.
in bip-0039/portuguese_brazilian.txt:227 in 31b89160cb
```
 222 | +bosque

 223 | +bossa

 224 | +bota

 225 | +boteco

 226 | +boxe

 227 | +brabo
```
brenorb commented at 6:50 PM on August 9, 2018:

Sounds very similar to "bravo", which is widely more used.
in bip-0039/portuguese_brazilian.txt:379 in 31b89160cb
```
 374 | +cosseno

 375 | +couro

 376 | +couve

 377 | +covarde

 378 | +coveiro

 379 | +coxa
```
brenorb commented at 6:53 PM on August 9, 2018:

Sounds identical to "cocha".
brenorb changes_requested
brenorb commented at 6:58 PM on August 9, 2018: contributor

I had no time to review the entire list, but this contribution seeks to pointing some words which might cause some confusion in Portuguese language.

I suggest discarding these ones and others which might have a similiar problem and picking new ones.
kuthullu closed this on Aug 9, 2018
kuthullu deleted the branch on Aug 9, 2018
brenorb commented at 3:51 PM on August 31, 2018: contributor
I worked some weeks in kuthullu's list to fix these issues and submitted a pull request #720 now with these rules:
1. Length between 4 and 8 characters.
2. Words can be uniquely determined typing the first 4 characters.
3. No accents or special characters.
4. No complex verb forms.
5. No plural words, unless there's no singular form.
6. No words with common double spelling, except when the only change is the accent.
7. No words with the exact sound of another word with different spelling.
8. No offensive words.
9. No words already used in other language mnemonic sets.
10. The words which have not the same spelling in Brazil and in Portugal are excluded.
iancoleman commented at 10:21 PM on October 9, 2018: contributor

@successhalf, asking once is enough. You asked the exact same question 4 times. I've responded to you in https://github.com/iancoleman/bip39/issues/261

https://github.com/iancoleman/bip39/issues/261 https://github.com/iancoleman/bip39/pull/144#issuecomment-428199268 https://github.com/iancoleman/bip39/pull/230#issuecomment-428199632
DonaldTsang cross-referenced this on Dec 24, 2018 from issue Binary Lists by DonaldTsang
DonaldTsang commented at 5:28 AM on December 24, 2018: none

@brenorb you ready to restart the wordlist optimization project?
brenorb commented at 10:01 PM on December 25, 2018: contributor

@brenorb you ready to restart the wordlist optimization project?

Well, @DonaldTsang, it's already done right here: #720 What are you planning?
tonnon commented at 3:10 PM on August 20, 2019: none

Any updates to add the Portuguese wordlist?
brenorb commented at 3:39 PM on August 21, 2019: contributor

Any updates to add the Portuguese wordlist?

It's been a year waiting for reviews. It's all done here: https://github.com/bitcoin/bips/pull/720
johnnyasantoss commented at 5:54 PM on August 21, 2019: none

Who can review that? I don't know any core dev that speaks/understands Portuguese.
brenorb commented at 6:02 PM on August 21, 2019: contributor

Who can review that? I don't know any core dev that speaks/understands Portuguese.

No one needs to be a core dev to review this PR. If you speek Portuguese I deeply encourage you to review it and leave a comment so they can properly accept or reject the PR.

Contributors

Labels

Proposed BIP modification

Linked (view graph)

#720 Add Portuguese wordlist