BIP158: add test vectors and generation code #668

pull aakselrod wants to merge 1 commits into bitcoin:master from aakselrod:bip0158-test-vectors changing 3 files +376 −1

aakselrod commented at 6:17 PM on April 3, 2018: contributor

In this PR, we add test vectors for filter and header construction and the code to generate them. The included test vectors are for testnet with a value of 20 for P. The code generates filters and headers for values of 1 through 32 for P using testnet blocks. Currently, to run the code, the Roasbeef fork of btcd (at https://github.com/roasbeef/btcd) is required to be running locally in testnet mode; this will be changed in a future PR after the code is merged into the btcsuite mainline.

BIP158: add test vectors and generation code

In this commit, we add test vectors for filter and header construction and
the code to generate them. The included test vectors are for testnet with a
value of 20 for P. The code generates filters and headers for values of 1
through 32 for P using testnet blocks. Currently, to run the code,
the `Roasbeef` fork of `btcd` (at https://github.com/roasbeef/btcd) is
required to be running locally in testnet mode; this will be changed in a
future commit after the code is merged into the `btcsuite` mainline.

3571e1a52d

MattLongCT commented at 7:02 PM on April 3, 2018: none

You certainly knocked that off the "TODO"! Code generation is properly formatted in my limited view.
MattLongCT approved
luke-jr merged this on Apr 8, 2018
luke-jr closed this on Apr 8, 2018

Contributors

aakselrod

MattLongCT