BIP 39: Аdd swift library with multi lang support #672

pull skywinder wants to merge 4 commits into bitcoin:master from skywinder:patch-1 changing 1 files +1 −0

skywinder commented at 7:21 AM on April 9, 2018: contributor

Add one more swift library to generate mnemonics (with multi lang support) Here is an implementation: https://github.com/matter-labs/web3swift/blob/e36e767eb2de26decb0c157aeef2d023a1175076/Sources/web3swift/KeystoreManager/BIP39.swift#L72

Update bip-0039.mediawiki

add one more library to generate mnemonics (with multilang support)

8c8a787206

skywinder renamed this:
~~Update bip-0039.mediawiki~~
Update bip-0039.mediawiki - added swift library with multi lang support
on Apr 9, 2018
skywinder renamed this:
~~Update bip-0039.mediawiki - added swift library with multi lang support~~
BIP 39: Аdd swift library with multi lang support
on Apr 9, 2018
Vilaiuk approved
Vilaiuk approved
skywinder commented at 8:42 PM on April 16, 2018: contributor

@luke-jr please, kindly check this small addition :wink:
update repo url 31ebc32e6f
skywinder commented at 3:06 PM on February 28, 2020: contributor

We moved our repo to the new address. I updated URL. Please, kindly check. 👍
luke-jr commented at 2:06 PM on April 30, 2020: member

@slush0 @prusnak @voisine @ebfull
luke-jr added the label Proposed BIP modification on Apr 30, 2020
prusnak commented at 2:16 PM on April 30, 2020: contributor

NAK. The URL points to the library that does other 1000 things than BIP39.

Maybe if the URL pointed to the relevant file ...
luke-jr closed this on Apr 30, 2020
in bip-0039.mediawiki:167 in 31ebc32e6f outdated
```
 164 | @@ -165,6 +165,7 @@ Rust:
 165 |  Swift:
 166 |  * https://github.com/CikeQiu/CKMnemonic
 167 |  * https://github.com/yuzushioh/WalletKit
```
skywinder commented at 4:20 PM on April 30, 2020:

(Would like to mention, that other links doesn't direect to the class itself)

prusnak commented at 8:27 AM on May 3, 2020:

They include the example of how generate a mnemonic right on top of their readme.
skywinder commented at 4:24 PM on April 30, 2020: contributor

Maybe if the URL pointed to the relevant file ... @luke-jr @prusnak can you reopen this PR, so I will update the link to the corresponding class? (or should I make another PR with the correct link? i.e. web3swift/KeystoreManager/BIP39.swift
luke-jr reopened this on Apr 30, 2020
Update link directly to the bip39 file 25b6d576b4
skywinder commented at 4:01 AM on May 3, 2020: contributor

Done, @luke-jr
remove duplicate line 91a835887d

in bip-0039.mediawiki:169 in 25b6d576b4 outdated

 164 | @@ -165,7 +165,8 @@ Rust:
 165 |  Swift:
 166 |  * https://github.com/CikeQiu/CKMnemonic
 167 |  * https://github.com/yuzushioh/WalletKit
 168 | -* https://github.com/matter-labs/web3swift (`BIP39` public class)
 169 | +* https://github.com/matter-labs/web3swift/blob/develop/Sources/web3swift/KeystoreManager/BIP39.swift
 170 | +* https://github.com/matter-labs/web3swift/blob/develop/Sources/web3swift/KeystoreManager/BIP39.swift

prusnak commented at 8:28 AM on May 3, 2020:

Once is enough

prusnak changes_requested
prusnak approved
luke-jr merged this on Jun 1, 2020
luke-jr closed this on Jun 1, 2020

Contributors

Labels

Proposed BIP modification