BIP 158: Change test vectors from CSV to JSON format. #677

pull jimpo wants to merge 1 commits into bitcoin:master from jimpo:bip158-test-vectors changing 3 files +118 −122

jimpo commented at 7:26 AM on May 1, 2018: contributor

The JSON format is standard for Bitcoin Core test data, and projects that copy test data from Core. This does some additional refactoring to the gentestvectors.go program. @aakselrod
BIP 158: Change test vectors from CSV to JSON format.
The JSON format is standard for Bitcoin Core test data.
fe1d3f84ba
aakselrod approved
aakselrod commented at 6:47 PM on May 2, 2018: contributor

utACK. For such small amounts of overhead, it might be more readable to make each test case a dictionary rather than usig a header row comment, but that wouldn't match the bitcoind tests.
jimpo commented at 5:47 AM on May 14, 2018: contributor

@luke-jr Ping
luke-jr merged this on May 20, 2018
luke-jr closed this on May 20, 2018

Contributors