Segwit wallets are still using xpub version prefix for segwit in p2sh/native segwit wallets. This is leading to incorrect address derivation from an xpub/xprv
Already in use by electrum, samouri and trezor
Hey @shivaenigma - thanks for the thought, but we don't modify BIP's to widen the scope after they have been finalized - given there already complete implementations of BIP32 in the wild.
Also these prefixes are already defined in SLIP-0132, and they should remain there IMO, unless someone wants to submit a standalone BIP for it. But the prefixes being defined in the SLIP repository haven't negatively affected their uptake. As you note, three wallets are using them already.
I think this PR is not acceptable due the above (though it's certainly not my place to decide that), but it may be acceptable if presented as a new BIP.
@afk11 Totally Understand point about not modifying existing BIP. No Problem
I will create a new BIP
Please open a new PR when you have a new BIP draft ready, following review of the draft on the bitcoin-dev ML.
@SomberNight you should submit your text here
Indeed we have a draft for this as a new BIP at https://github.com/SomberNight/bips/blob/bip-xpub-versionbytes-extension/bip-xpub-versionbytes-extension.mediawiki I think I'll read it a few more times and potentially clean it up a bit, and submit it to the mailing list soon
@SomberNight Thanks ... looks good .. I have few tests here. Feel free to copy
Looking forward to the submission to the mailing list
Why not submit updates and changes to SLIP-0132? There are (a few) test vectors and a generation code there as well.