Fix: japanese words #685

pull dongri wants to merge 1 commits into bitcoin:master from hackerth:master changing 1 files +644 −644

dongri commented at 2:35 PM on May 28, 2018: none

Change Japanese word

like だ -> だ

irb(main):003:0> "だ".bytesize
=> 6
irb(main):004:0> "だ".bytesize
=> 3
irb(main):005:0>

Fix: japanese words e2f81e14ea
dabura667 commented at 2:57 PM on May 28, 2018: none

Please read the BIP.

All wordlists must be unicode NFKD normalized.

NFKD正規化された状態で単語リストを保有しないとバグ出ますよ。お気をつけて下さい。
dabura667 commented at 2:57 PM on May 28, 2018: none

NACK
dongri commented at 3:07 PM on May 28, 2018: none

@dabura667 Thank you

BIP39 Test vectors https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki#test-vectors

https://github.com/bip32JP/bip32JP.github.io/blob/master/test_JP_BIP39.json

Is the test data incorrect? Not unicode NFKD normalized
dongri commented at 3:19 PM on May 28, 2018: none

oh... I misunderstood the specification.
dongri closed this on May 28, 2018

Contributors