Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly #727

1. 
   mmgen commented at 6:17 pm on September 27, 2018: contributor

   Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly.

   Diff: -This results in a Base58-encoded string of up to 112 characters. +This results in a Base58-encoded string of exactly 111 characters.

   Proof: Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”)

   Largest version byte is 0x0488b21e, smallest 0x04358394.

   Largest “possible” key:

   0kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes)
   1b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY
   2len(b58chk(kL)) = 111
   

   Smallest “possible” key:

   0kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes)
   1b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF
   2len(b58chk(kS)) = 111
   

2. Add Trust to compatible wallets c79576c759
3. Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly.

   -This results in a Base58-encoded string of up to 112 characters.
   +This results in a Base58-encoded string of exactly 111 characters.
   
   Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”)
   
   Largest “possible” key:
      kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes)
      b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY (111 chars)
   
   Smallest “possible” key:
      kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes)
      b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF (111 chars)

   81644ddfa1
4. luke-jr added the label Proposed BIP modification on Sep 27, 2018
5. 
   luke-jr commented at 6:28 pm on September 27, 2018: member

   @sipa
6. fix bip-0016 link 404 433283d671
7. Merge pull request #726 from vikmeup/patch-1

   Add Trust to compatible wallets

   33e040b7bd
8. Merge pull request #728 from kaidiren/patch-1

   fix bip-0016 link 404

   4b21d27946
9. unknown approved
10. Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP accordingly.

    -This results in a Base58-encoded string of up to 112 characters.
    +This results in a Base58-encoded string of exactly 111 characters.
    
    Version bytes: 0x0488b21e (“xpub”), 0x0488ade4 (“xprv”), 0x043587cf (“tpub”), 0x04358394 (“tprv”)
    
    Largest “possible” key:
       kL = 0x0488b21effffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff (78 bytes)
       b58chk(kL) = xpubEPi3iGSX9RiyuXPTijevUmMctBDQs2TWCMgUd3qKp6qCgUc8RUsPdPBrRC6whFeWTg37DcmnJJiKFL73DH4sjdApJkXBD3vFcBP4xHq3fPY (111 chars)
    
    Smallest “possible” key:
       kS = 0x043583940000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 (78 bytes)
       b58chk(kS) = tprv8ZgxMBicQKsPcsbCVeqqF1KVdH7gwDJbxbzpCxDUsoXHdb6SnTPYxdwSAKDC6KKJzv7khnNWRAJQsRA8BBQyiSfYnRt6zuu4vZQGKjeW4YF (111 chars)

    aa723fab8e
11. Merge branch 'bip32-patch' of https://github.com/mmgen/bips into bip32-patch 7602da679d
12. murchandamus changes_requested
13. 
    murchandamus commented at 7:04 pm on April 30, 2024: contributor

    I’m not sure how exactly this PR came together, but the change to BIP44 is no longer compatible with BIP44 after the “Compatible wallets” section got removed via #770.

    If you would still like to pursue the changes to BIP16 and BIP32, it might be best if those changes were opened as separate PRs, given that they need sign-off from different authors.

14. 
    jonatack commented at 9:20 pm on April 30, 2024: contributor

    Agree, closing. As the author was last active six years ago, I’ll open separate BIP-specific pulls with a cherry-picked commit by the original author.
15. jonatack closed this on Apr 30, 2024

    ---

16. in bip-0016/qa.mediawiki:1 in 7602da679d

    0@@ -1,4 +1,4 @@
    1-This page is a Quality Assurance test plan for [[BIP 16]].  If you see a test missing, please add it.
    2+This page is a Quality Assurance test plan for [[../bip-0016.mediawiki|BIP 16]].  If you see a test missing, please add it.
    

    ---

    ---

    

    jonatack commented at 9:49 pm on April 30, 2024:

    This has been fixed in 433283d671482f4f8467168e46cf44c4fe105691.
17. 
    jonatack commented at 9:57 pm on April 30, 2024: contributor

    Superseded by #1584 that cherry-picks 81644ddfa131bb0e387ead2cc309ca18e57542b1.

Contributors
mmgen luke-jr murchandamus jonatack

Labels
Proposed BIP modification