bip158: update test vectors #733

pull tuxcanfly wants to merge 1 commits into bitcoin:master from tuxcanfly:bip158-update-tests changing 1 files +2 −0

tuxcanfly commented at 3:53 PM on October 25, 2018: contributor

Added test vector for block 1414221. In particular this block has no output scripts other than OP_RETURN, and it's corresponding filter is 0x00. Also updated the spec to clarify the same.
tuxcanfly force-pushed on Oct 25, 2018
luke-jr commented at 4:49 PM on December 14, 2018: member

@Roasbeef @aakselrod
luke-jr added the label Proposed BIP modification on Dec 14, 2018
bip158: update test vectors 9b03604c5b

in bip-0158.mediawiki:282 in d2b1dc9c00 outdated

 278 | @@ -279,7 +279,8 @@ following items for each transaction in a block:
 279 |  * The scriptPubKey of each output, aside from all <code>OP_RETURN</code> output
 280 |    scripts.
 281 |  
 282 | -Any "nil" items MUST NOT be included into the final set of filter elements.
 283 | +Any "nil" items MUST NOT be included into the final set of filter elements. A

jimpo commented at 4:07 AM on February 13, 2019:

I'm not sure this is necessary, as it is implied by the construction. However, if you think it's useful to clarify, I'd include the sentence at the end of the "Construction" section, not here.

tuxcanfly commented at 10:51 AM on February 13, 2019:

Moved.

tuxcanfly force-pushed on Feb 13, 2019
murchandamus assigned Roasbeef on Apr 23, 2024
Roasbeef commented at 9:25 PM on April 23, 2024: contributor

The test vector additions moved over to: #760

Fine with this as is, nothing lost by calling out the explicit case of an empty filter.
Roasbeef approved
Roasbeef commented at 9:25 PM on April 23, 2024: contributor

LGTM 🦚
Roasbeef merged this on Apr 23, 2024
Roasbeef closed this on Apr 23, 2024

Contributors

Labels

Proposed BIP modification