[WIP] bip-322: strip out proof-of-funds related stuff and fix several issues #744

pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:bip322-fixes changing 1 files +32 −31
  1. kallewoof commented at 6:20 AM on December 3, 2018: member

    Simplifies BIP-322 to ONLY address signing/verifying a message, removing traces of proof-of-funds. Also adds some missing fields that were asked for, such as lock time and sequence.

    The intention is to make a separate BIP which builds on top of this one for the proof of funds part.

    Edit: I am still trying to figure out this and a separate BIP which addresses the proof of funds part. Not ready for merging yet.

  2. kallewoof force-pushed on Dec 3, 2018
  3. bip-322: strip out proof-of-funds related stuff and fix several issues df9c2fc6de
  4. kallewoof force-pushed on Dec 3, 2018
  5. kallewoof renamed this:
    bip-322: strip out proof-of-funds related stuff and fix several issues
    [WIP] bip-322: strip out proof-of-funds related stuff and fix several issues
    on Dec 3, 2018
  6. stevenroose commented at 12:39 PM on December 3, 2018: contributor

    @kallewoof Been trying to do a proof-of-reserves BIP with another approach: https://github.com/stevenroose/bips/tree/por

    It has an optional PSBT extension for integration too. I'm finishing it up in order to write to the mailing list. Any early feedback would be appreciated.

  7. kallewoof commented at 3:41 AM on December 4, 2018: member

    @stevenroose I haven't looked at your proposal yet, but it feels like the two standards are very closely related and everyone would benefit from them being integrated with respect to each other. I have a work in progress for proof of funds already on my end, but having two proposals can only be good for the community as long as they're judged purely on their merits.

    That being said, please keep BIP 322 compatibility in consideration in your proposal.

  8. stevenroose commented at 4:49 PM on December 4, 2018: contributor

    But the proposal I worked out has nothing to do with signed messages. The proofs are just serialized transactions. And yeah, I totally agree we should compare proposals and try to reach some form of consensus. Do you have anything public about your proposal?

  9. luke-jr merged this on Feb 15, 2019
  10. luke-jr closed this on Feb 15, 2019

  11. harding commented at 8:37 PM on February 16, 2019: contributor

    @luke-jr why was a WIP pull request whose OP said "Not ready for merging yet" merged?

  12. luke-jr commented at 12:16 AM on February 17, 2019: member

    Oops, this isn't really the place for WIPs... @kallewoof Do you want this reverted?

  13. kallewoof commented at 1:48 AM on February 20, 2019: member

    Sorry for late reply -- yes, sorry I should've closed this until I had time to actually work on it. Please revert. Sorry for the trouble.

  14. luke-jr commented at 9:19 AM on February 20, 2019: member

    Reverted

  15. luke-jr referenced this in commit b4853407a7 on Feb 20, 2019
  16. turbobit referenced this in commit 30a6098944 on Feb 20, 2019
  17. turbobit referenced this in commit 8c73bbf39c on Feb 20, 2019
  18. matthewjablack referenced this in commit 68faeeab52 on Mar 29, 2019
  19. thephez referenced this in commit 9d8ff020b8 on May 9, 2019
  20. kallewoof deleted the branch on Jul 22, 2019

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 08:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me