BIP-49 - Add Version Bytes Section #762

pull clarkmoody wants to merge 3 commits into bitcoin:master from clarkmoody:bip-49-version-bytes changing 1 files +11 −2

clarkmoody commented at 6:29 PM on February 14, 2019: contributor
Added version bytes section in parallel with #761.
- Update test vectors with new version bytes
cc @DanielWeigl
clarkmoody cross-referenced this on Feb 14, 2019 from issue BIP-84 - Add Version Bytes Section by clarkmoody
prusnak commented at 6:34 PM on February 14, 2019: contributor

ACK. Should we add link to https://github.com/satoshilabs/slips/blob/master/slip-0132.md?
luke-jr added the label Proposed BIP modification on Feb 15, 2019
clarkmoody cross-referenced this on Jul 23, 2019 from issue Update bip-0049.mediawiki by torkelrogstad
Add version bytes section 4413bdc46f
Link to SLIP-0132 75ae8418da
Update test vectors with new version bytes 5b74e93fcb
clarkmoody force-pushed on Jul 23, 2019
clarkmoody renamed this:
~~[WIP] BIP-49 - Add Version Bytes Section~~
BIP-49 - Add Version Bytes Section
on Jul 23, 2019
clarkmoody commented at 4:16 PM on July 23, 2019: contributor

Ready for review @DanielWeigl. Update test vectors with new version bytes.
DanielWeigl commented at 7:53 AM on July 24, 2019: contributor

Ah, sorry - missed that github notification. Checked testvector against electrum.

LGTM
clarkmoody commented at 3:41 AM on July 26, 2019: contributor

@luke-jr I think we're good to go here.
luke-jr merged this on Jul 26, 2019
luke-jr closed this on Jul 26, 2019

Contributors

Labels