The golomb_encode function should encode r instead of x.
Fix pseudocode on bip-0158 #769
pull AlexITC wants to merge 1 commits into bitcoin:master from AlexITC:patch-1 changing 1 files +2 −1-
AlexITC commented at 6:15 AM on March 12, 2019: none
-
fcb7aeb7e2
Fix pseudocode on bip-0158
The golomb_encode function should encode r instead of x.
-
luke-jr commented at 6:01 AM on March 29, 2019: member
- luke-jr added the label Proposed BIP modification on Mar 29, 2019
-
AlexITC commented at 12:43 AM on April 3, 2019: none
I'm not sure what the
Proposed BIP modificationtag is about, I'm not proposing to change the BIP but fixing a minor detail on the pseudocode. - Namhvan approved
-
matthewleon commented at 11:40 PM on May 13, 2019: none
This appears to be an unnecessary change to the pseudocode. See the Bitcoin core implementation: https://github.com/bitcoin/bitcoin/blob/667a8617418d837092de5b37568d60b372519462/src/blockfilter.cpp#L37
-
AlexITC commented at 4:26 AM on May 14, 2019: none
@mattBlackDesign in fact, it wasn't obvious to me that this line is writing the
Pleast significant bits only, which is what I basically made clear:write_bits_big_endian(stream, r, P).I'm closing the ticket.
- AlexITC closed this on May 14, 2019
Contributors
