While the Transaction Extractor section calls out the 0x05 Finalized scriptSig and 0x06 Finalized scriptWitness, this wasn’t as clear in the Input Finalizer section.
BIP174: Input Finalizer finalized fields clarifications #771
pull bitschmidty wants to merge 1 commits into bitcoin:master from bitschmidty:master changing 1 files +1 −1-
bitschmidty commented at 3:04 PM on March 19, 2019: contributor
- bitschmidty renamed this:
Input Finalizer finalized fields clarifications
BIP174: Input Finalizer finalized fields clarifications
on Mar 19, 2019 -
kallerosenbaum commented at 8:08 PM on March 24, 2019: contributor
It's actually 0x07 (Finalized scriptSig) and 0x08 (Finalized scriptWitness). The references are wrong in the Transaction Extractor section. See #765
-
bitschmidty commented at 2:01 PM on March 25, 2019: contributor
@kallerosenbaum Thank you, I should have verified what I was referencing! Corrections made.
-
kallerosenbaum commented at 3:03 PM on March 25, 2019: contributor
Ok, but now this PR conflicts with pending PR #765 that fixes the errors in "Input Finalizer" section.
-
bitschmidty commented at 2:21 PM on March 26, 2019: contributor
Updated to remove conflict
- luke-jr added the label Proposed BIP modification on Mar 29, 2019
-
-
achow101 commented at 2:18 PM on March 29, 2019: member
Please squash.
Otherwise, ACK
- bitschmidty force-pushed on Jun 9, 2020
- bitschmidty force-pushed on Jun 9, 2020
- bitschmidty force-pushed on Jun 9, 2020
-
bip-0174: Input Finalizer finalized fields clarifications 3dbd4866b7
- bitschmidty force-pushed on Jun 9, 2020
-
bitschmidty commented at 7:41 PM on June 9, 2020: contributor
- luke-jr merged this on Jun 12, 2020
- luke-jr closed this on Jun 12, 2020
