The BIP151 proposal does have some practical downsides and thus a new proposal has been made (https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52)
Withdraw BIP151 #772
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2019/03/withdraw_BIP151 changing 2 files +3 −3-
jonasschnelli commented at 9:08 PM on March 22, 2019: contributor
-
luke-jr commented at 5:55 AM on March 29, 2019: member
BIP 151 never left Draft status, so why not just revise it?
-
sipa commented at 6:13 AM on March 29, 2019: member
Given that BIP151 already has an assigned number, I think it would be inadvisable to keep using the same number for a substantially different design.
-
luke-jr commented at 6:30 AM on March 29, 2019: member
Number assignment is not finalisation. Maybe if there was a production implementation of it, but as a mere draft, I don't see why. The new one is still "Peer-to-Peer Communication Encryption", no?
-
jonasschnelli commented at 8:00 AM on March 29, 2019: contributor
The main reason why this number/proposal should and probably cannot be re-used for a new, heavy incompatible proposal is, that implementations have been made (bcoin, armory). I don't think they are (no longer) in production but still,... the code is available.
-
luke-jr commented at 8:16 AM on March 29, 2019: member
I'm not really convinced, but not worth spending time arguing...
The README needs a style change, though: |- style="background-color: #ffcfcf"
- jonasschnelli force-pushed on Mar 29, 2019
-
jonasschnelli commented at 9:06 AM on March 29, 2019: contributor
The README needs a style change, though: |- style="background-color: #ffcfcf"
Done.
-
luke-jr commented at 9:48 AM on March 29, 2019: member
... the style change is needed for BIP 151, not BIP 152 ;)
-
Withdraw BIP151 73d06b4a13
- jonasschnelli force-pushed on Mar 29, 2019
-
jonasschnelli commented at 7:52 PM on March 29, 2019: contributor
Fixed
- luke-jr merged this on Apr 4, 2019
- luke-jr closed this on Apr 4, 2019
- ysangkok cross-referenced this on Feb 4, 2021 from issue Reject 150 (expired) by ysangkok
Contributors
Linked (view graph)