BIP-158: Remove some remaining "extended" mentions #799

pull stevenroose wants to merge 1 commits into bitcoin:master from stevenroose:nit-bip158 changing 1 files +1 −1

stevenroose commented at 9:20 AM on July 4, 2019: contributor

The extended filter type was removed in #687, but some mentions were still present in the document. They can be confusing.
stevenroose commented at 9:21 AM on July 4, 2019: contributor

Please review, @Roasbeef @aakselrod
MarcoFalke commented at 9:26 PM on July 8, 2019: member
See also:
- BIP 158: remove old reference to extended filter type #787
stevenroose cross-referenced this on Jul 9, 2019 from issue BIP 158: remove old reference to extended filter type by fjahr
stevenroose commented at 3:37 PM on July 9, 2019: contributor

This can be closed if #787 also takes out the filter type code usage. I wasn't aware of that PR, my apologies.
luke-jr added the label Proposed BIP modification on Jul 23, 2019

in bip-0158.mediawiki:325 in 4c133eb7dd outdated

 320 | @@ -323,7 +321,7 @@ This BIP allocates a new service bit:
 321 |  |-
 322 |  | NODE_COMPACT_FILTERS
 323 |  | style="white-space: nowrap;" | <code>1 << 6</code>
 324 | -| If enabled, the node MUST respond to all BIP 157 messages for filter types <code>0x00</code> and <code>0x01</code>
 325 | +| If enabled, the node MUST respond to all BIP 157 messages for filter type <code>0x00</code>

Roasbeef commented at 12:34 AM on July 26, 2019:

If #787 goes in, then we only need this section.

Roasbeef commented at 3:03 AM on July 26, 2019: contributor

Can be rebased now that #787 has landed.
stevenroose force-pushed on Jul 26, 2019
BIP-158: Remove some remaining "extended" mentions 30292b727e
stevenroose commented at 9:36 AM on July 26, 2019: contributor

rebased
MarcoFalke cross-referenced this on Sep 25, 2019 from issue BIP 158: Fix mediawiki syntax typo, Remove remnants of the second filter type by MarcoFalke
Roasbeef commented at 2:23 AM on October 25, 2019: contributor

#845 includes this fix (and others), so I think we can merge that instead.
luke-jr closed this on Oct 25, 2019

Contributors

stevenroose

MarcoFalke

Roasbeef

Labels

Proposed BIP modification

Linked (view graph)

#687 BIP-0158: remove extended filter, remove txid from regular filter, reparameterize gcs params #787 BIP 158: remove old reference to extended filter type #845 BIP 158: Fix mediawiki syntax typo, Remove remnants of the second filter type