Clarify pseudocode for lift_x() (jnewbery) #832

pull sipa wants to merge 22 commits into bitcoin:master from sipa:201908_computec changing 8 files +1035 −0

sipa commented at 9:37 PM on August 21, 2019: member
Rebase of #47
- define c
- return x as the x-co-ordinate, not the undefined r
- explicitly state that the return object is a point (and not eg an array or tuple of ints)

Add draft for Schnorr BIP

Includes squashed contributions by GitHub users jonasnick,
real-or-random, AustinWilliams, JustinTArthur, ysangkok,
RCassatta, Sjors, tnakagawa, and guggero.

aeffa07527

Add taproot/tapscript bips drafts 6733024595
Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash' e9ea1710ef

Merge pull request #30 from jonasnick/clarify-reduce

Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'

271e5db6d7

remove duplicate warning

Though perhaps, the emphasis is warranted given its importance. :-)

d194620af9

Merge pull request #40 from markblundeberg/patch-1
remove duplicate warning
27e61d61e6

taproot_output_script: first returned byte should be OP_1 (0x51)

If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51

0c49346c87

Merge pull request #41 from dgpv/patch-1

taproot_output_script: first returned byte should be OP_1 (0x51)

b55fed9f86

Clarify diagram 04b844540e
Merge pull request #42 from jonasnick/clarify-diagram
Clarify description of diagram
084dee847d
Fix point_from_bytes in bip-schnorr reference implementation 1faf705388
Switch to 32 byte public keys in bip-schnorr ed01c1a776
Use short public keys for taproot output keys 5793d3d735
Clarify how to disable key path spending 9795b7081a
Address Tim's comments 112d9c150a

Update bip-schnorr.mediawiki

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

30fdc87599

Update bip-schnorr/test-vectors.py

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

ae96228913

Address sipa's feedback 0d28b3c37b

Merge pull request #55 from jonasnick/bip-schnorr32

Completely switch to 32-byte public keys in bip-schnorr/taproot/tapscript

28dc94f36c

Merge pull request #43 from jonasnick/script-path-only
Clarify how to disable key path spending
4fef743de7
Define c in lift_x(x) ad91099b8f
Return a point from lift_x() a462876b9a
sipa commented at 9:38 PM on August 21, 2019: member

Oops, wrong repo.
sipa closed this on Aug 21, 2019

Contributors

sipa

Linked (view graph)

#47 Update bip-0038.mediawiki