Rebase of #44 #841

sipa commented at 11:04 PM on September 10, 2019: member

No description provided.

Add draft for Schnorr BIP

Includes squashed contributions by GitHub users jonasnick,
real-or-random, AustinWilliams, JustinTArthur, ysangkok,
RCassatta, Sjors, tnakagawa, and guggero.

aeffa07527

Add taproot/tapscript bips drafts 6733024595

Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash' e9ea1710ef

Merge pull request #30 from jonasnick/clarify-reduce

Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'

271e5db6d7

remove duplicate warning

Though perhaps, the emphasis is warranted given its importance. :-)

d194620af9

Merge pull request #40 from markblundeberg/patch-1

remove duplicate warning

27e61d61e6

taproot_output_script: first returned byte should be OP_1 (0x51)

If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51

0c49346c87

Merge pull request #41 from dgpv/patch-1

taproot_output_script: first returned byte should be OP_1 (0x51)

b55fed9f86

Clarify diagram 04b844540e

Merge pull request #42 from jonasnick/clarify-diagram

Clarify description of diagram

084dee847d

Fix point_from_bytes in bip-schnorr reference implementation 1faf705388

Switch to 32 byte public keys in bip-schnorr ed01c1a776

Use short public keys for taproot output keys 5793d3d735

Clarify how to disable key path spending 9795b7081a

Address Tim's comments 112d9c150a

Update bip-schnorr.mediawiki

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

30fdc87599

Update bip-schnorr/test-vectors.py

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

ae96228913

Address sipa's feedback 0d28b3c37b

Merge pull request #55 from jonasnick/bip-schnorr32

Completely switch to 32-byte public keys in bip-schnorr/taproot/tapscript

28dc94f36c

Merge pull request #43 from jonasnick/script-path-only

Clarify how to disable key path spending

4fef743de7

Define c in lift_x(x) ad91099b8f

Return a point from lift_x() a462876b9a

Replace 'quadratic residue of...' 8492968f34

Merge pull request #48 from jnewbery/2019-05-quadratic-residue

Reword 'quadratic residue of...'

de9bc9c72c

Merge pull request #58 from sipa/201908_computec

Clarify pseudocode of lift_x

abe79d81e3

Use key path spend terminology more consistently in taproot/tapscript 16bdfcf534

Merge pull request #56 from jonasnick/keypath

Use key path spend terminology more consistently in taproot/tapscript

de990a1128

Use a tagged hash in bip-schnorr nonce derivation 7cd53f6eec

Tag signature hashes, improve rationale and update test vectors 775cb2fd90

Address sipa's comments dc6b91c1a9

Merge pull request #61 from jonasnick/tagged-derive

Use a tagged hash in bip-schnorr nonce derivation

e1f199989b

public keys aren't identical e9600e6ed8

pk not p 01e1f6e6b2

make secret key a 32-byte array called sk, introduce pubkey() 4643538d4f

use p for taproot internal key d3951f63f3

key gen, verify, sign in intro fc74ec6b35

note about pubkey collision 30bc716add

Fix privkey negation in taproot_sign_key 02bdf88ef9

Merge pull request #63 from jonasnick/fix-sign-key

Fix privkey negation in taproot_sign_key

51a84fd407

Merge pull request #59 from ajtowns/201908-schnorr32-nits

32 byte pubkey nits

6653f9f883

Add a footnote about 32-byte security 4a383064fb

Merge pull request #64 from real-or-random/patch-7

Add a footnote about 32-byte security

eabf7c9a6d

Move plain public key in output rationale to design section

Rebased by Pieter Wuille

0995c8a5b5

sipa closed this on Sep 10, 2019