201910 simple fixes #855

sipa commented at 12:56 AM on October 15, 2019: member

No description provided.

Add draft for Schnorr BIP

Includes squashed contributions by GitHub users jonasnick,
real-or-random, AustinWilliams, JustinTArthur, ysangkok,
RCassatta, Sjors, tnakagawa, and guggero.

aeffa07527

Add taproot/tapscript bips drafts 6733024595

Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash' e9ea1710ef

Merge pull request #30 from jonasnick/clarify-reduce

Clarify what 'reduced' means in tests and use word 'message' instead of 'message hash'

271e5db6d7

remove duplicate warning

Though perhaps, the emphasis is warranted given its importance. :-)

d194620af9

Merge pull request #40 from markblundeberg/patch-1

remove duplicate warning

27e61d61e6

taproot_output_script: first returned byte should be OP_1 (0x51)

If we look at

  def IsPayToTaproot(script):
      return len(script) == 35 and script[0] == OP_1 and script[1] == 33 and script[2] >= 0 and script[2] <= 1

First byte is is checked for OP_1. OP_1 is 0x51

But the example code in this BIP returns  

`bytes([0x01, 0x21, output_pubkey[0] & 1]) + output_pubkey[1:]`

First byte 0x01, but it should be 0x51

0c49346c87

Merge pull request #41 from dgpv/patch-1

taproot_output_script: first returned byte should be OP_1 (0x51)

b55fed9f86

Clarify diagram 04b844540e

Merge pull request #42 from jonasnick/clarify-diagram

Clarify description of diagram

084dee847d

Fix point_from_bytes in bip-schnorr reference implementation 1faf705388

Switch to 32 byte public keys in bip-schnorr ed01c1a776

Use short public keys for taproot output keys 5793d3d735

Clarify how to disable key path spending 9795b7081a

Address Tim's comments 112d9c150a

Update bip-schnorr.mediawiki

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

30fdc87599

Update bip-schnorr/test-vectors.py

Co-Authored-By: Tim Ruffing <tim@timruffing.de>

ae96228913

Address sipa's feedback 0d28b3c37b

Merge pull request #55 from jonasnick/bip-schnorr32

Completely switch to 32-byte public keys in bip-schnorr/taproot/tapscript

28dc94f36c

Merge pull request #43 from jonasnick/script-path-only

Clarify how to disable key path spending

4fef743de7

Define c in lift_x(x) ad91099b8f

Return a point from lift_x() a462876b9a

Replace 'quadratic residue of...' 8492968f34

Merge pull request #48 from jnewbery/2019-05-quadratic-residue

Reword 'quadratic residue of...'

de9bc9c72c

Merge pull request #58 from sipa/201908_computec

Clarify pseudocode of lift_x

abe79d81e3

Use key path spend terminology more consistently in taproot/tapscript 16bdfcf534

Prescribe that a taproot output key should always have a taproot commitment ed0bb5b0c2

Merge pull request #56 from jonasnick/keypath

Use key path spend terminology more consistently in taproot/tapscript

de990a1128

Use a tagged hash in bip-schnorr nonce derivation 7cd53f6eec

Tag signature hashes, improve rationale and update test vectors 775cb2fd90

Address sipa's comments dc6b91c1a9

Merge pull request #61 from jonasnick/tagged-derive

Use a tagged hash in bip-schnorr nonce derivation

e1f199989b

public keys aren't identical e9600e6ed8

pk not p 01e1f6e6b2

make secret key a 32-byte array called sk, introduce pubkey() 4643538d4f

use p for taproot internal key d3951f63f3

key gen, verify, sign in intro fc74ec6b35

note about pubkey collision 30bc716add

Fix privkey negation in taproot_sign_key 02bdf88ef9

Merge pull request #63 from jonasnick/fix-sign-key

Fix privkey negation in taproot_sign_key

51a84fd407

Merge pull request #59 from ajtowns/201908-schnorr32-nits

32 byte pubkey nits

6653f9f883

Rework Applications section 6d99e45126

Add a footnote about 32-byte security 4a383064fb

Merge pull request #64 from real-or-random/patch-7

Add a footnote about 32-byte security

eabf7c9a6d

Move plain public key in output rationale to design section

Rebased by Pieter Wuille

0995c8a5b5

Merge pull request #49 from jonasnick/key-aggregation-security

Prescribe that an output key should always have a taproot commitment

a02dbdc850

Merge pull request #65 from real-or-random/patch-6

Rework Applications section

10073d1ca5

Address some nits fa423aced9

Merge pull request #66 from sipa/jonasnick_design

Move plain public key in output rationale to design section (rebase of #44)

9424700d78

Merge pull request #68 from sipa/nits_real-or-random_patch-6

Address some nits

7c37e721de

Mention SHA256 block size

Rebased by Pieter Wuille

87fa069b8f

Merge pull request #67 from sipa/jonasnick_small-fixes

Mention SHA256 block size (rebase of #45)

463a55935b

Removed reference to 0xc1 leaf version.

No longer necessary with 32B pubkeys.

d191359e75

bip-taproot: fix small typo (is does not) 1a8818a446

Merge pull request #70 from kanzure/bip-taproot-fix-typo

bip-taproot: Fix minor grammar issue

849580166a

Merge pull request #69 from jachiang/2019-09-leaf-version

Removed reference to 0xc1 leaf version.

55beff3376

Move/reword tagged hashes motivation 77dad346ec

Rework resource limits section f2899666f8

Remove P2SH support 1ee15f7dd9

Euler's Criterion prime only nit aa463b8193

Merge pull request #74 from elichai/patch-2

Euler's Criterion prime only nit

b9927356aa

Merge pull request #72 from sipa/201909_no_p2sh

Remove P2SH support

2d2e268ee8

Merge pull request #73 from sipa/201909_limits

Rework resource limits section

6aa933b178

Fixups 079ae4b048

Merge pull request #71 from sipa/201909_fix_tag_rationale

Move/reword tagged hashes motivation

05efb5de84

Merge pull request #76 from sipa/201909_tapscript_resource_fixups

Fixups

d51109a03f

Extend codeseparator_position from 16 to 32 bits 4c2eb9a600

Extend input_index from 16 to 32 bits 0d5ac28f2c

typo 7ce33c01ec

separate p2sh wrapped security rationale f831386103

Merge pull request #78 from ajtowns/201909-p2sh80b

minor wording fixes

9033e43001

Remove 0xc1 479fe5f365

Merge pull request #79 from jonasnick/0xc1

Remove 0xc1

8d893f9c06

Accept seckey in the form of bytes and not int in the reference BIP-schnorr code to match the spec. 472911379c

Add x() and y() functions for points to bip-schnorr 7e273fbda6

Standardize on secret key in bip-schnorr 5c52872fe0

Add is_quad function to bip-schnorr reference code 1882aa7b8f

Add taproot_tweak_pubkey and taproot_tweak_privkey functions to bip-taproot wallet section 398897cd29

Replace taproot_tweak_pubkey assertion with exception and add it to taproot_tweak_seckey too a6e5c16821

Link to Schnorr's paper instead of Wikipedia 3f61b2b1e7

Merge pull request #81 from jonasnick/tweaks

Improve readability of bip-taproot wallet section

730feed75a

Merge pull request #82 from real-or-random/patch-8

Link to Schnorr's paper instead of Wikipedia

90d9e21825

Merge pull request #80 from jonasnick/bytes

Accept seckey in the form of bytes and not int in the reference BIP-schnorr code...

00f941b8c7

Merge pull request #77 from sipa/201909_bigger_opspos

Extend codeseparator_position and input_index from 16 to 32 bits

4aa889e6ac

Fix formula 15d5aa2732

Increase max Merkle path length 6b72dfff51

Merge pull request #83 from sipa/branch_limit

Increase max Merkle path length

e5888935ca

Small fix: 0xc1 is possible as first control block byte 9413cc1f07

Merge pull request #85 from sipa/201910_c1

Small fix: 0xc1 is possible as first control block byte

c8e82957a2

Small fixes from review with real-or-random 69f1c93d92

sipa commented at 12:56 AM on October 15, 2019: member

Grr.

sipa closed this on Oct 15, 2019