BIP174: remove 'first byte is the type' comment for key data #866

pull dgpv wants to merge 1 commits into bitcoin:master from dgpv:patch-6 changing 1 files +1 −1
  1. dgpv commented at 7:21 AM on December 9, 2019: contributor

    As the key type is now defined as compact size integer, At the beginning of each key is a compact size unsigned integer representing the type, the comment in the first table in the document, about first byte of the key being the key type is no longer accurate.

    As the structure of the key data is described further in the text after the table, and the comment that it starts with the compact size integer seems a bit long to be in that table, I think it is better to just remove the comment about the key data structure from the table, and leave the explanation to the text after the table.

  2. BIP174: remove 'first byte is the type' comment for key data
    As the key type is now defined as compact size integer, `At the beginning of each key is a compact size unsigned integer representing the type`, the comment in the first table in the document, about first byte of the key being the key type is no longer accurate.
    
    As the structure of the key data is described further in the text after the table, and the comment that it starts with the compact size integer seems a bit long to be in that table, I think it is better to just remove the comment about the key data structure from the table, and leave the explanation to the text after the table.
    267c02a4b5
  3. achow101 commented at 5:57 PM on December 9, 2019: member

    ACK 267c02a4b5c5550309b84bd60b6f72d9989ffb9b

  4. luke-jr merged this on Dec 13, 2019
  5. luke-jr closed this on Dec 13, 2019

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 07:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me