Replace elixir bip39 implementation #891

pull aerosol wants to merge 1 commits into bitcoin:master from aerosol:replace-elixir-bip39-implementation changing 1 files +1 −1

aerosol commented at 12:10 AM on February 21, 2020: contributor
Follow up to #883

Advantages:
- 100% test coverage + CI set up
- smaller tests that strictly address properties of the specs
- documentation
- vectors.json identical to Trezor's + tests for seed verification with a passphrase
- idiomatic code, no compilation warnings, no unnecessary conversions to strings containing binary numbers
- flexible interface, e.g. works with raw binaries as well as hex-encoded
- does not output 1.5M of text when running tests
- does not confuse entropy with a private key
- no commented out code
- descriptive commit log @prusnak let me know if you'd like me to squash the commits
prusnak commented at 10:31 AM on February 21, 2020: contributor

ACK if the commits are squashed
Update BIP39 Elixir implementation 1a42bb3450
aerosol force-pushed on Feb 21, 2020
aerosol commented at 10:57 AM on February 21, 2020: contributor

@prusnak done, thanks
aerosol commented at 1:04 PM on February 25, 2020: contributor

@prusnak let me know if this looks good please. Cheers.
prusnak commented at 1:13 PM on February 25, 2020: contributor

ack
aerosol commented at 10:03 AM on February 26, 2020: contributor

Could you merge then? Thanks
prusnak commented at 12:54 PM on February 26, 2020: contributor

I can't. I am not an owner/maintainer of this repo
aerosol commented at 3:30 PM on February 26, 2020: contributor

@luke-jr please have a look, thank you
luke-jr merged this on Feb 28, 2020
luke-jr closed this on Feb 28, 2020
aerosol deleted the branch on Mar 17, 2020

Contributors

aerosol

prusnak

Linked (view graph)

#883 Add BIP39 Elixir implementation (mnemo)