add more tests for leading zero #905

1. 
   klim0v commented at 8:52 pm on April 4, 2020: none

   In the library btcsuite/btcutil and decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case.

   0seed: "57fb1e450b8afb95c62afbcd49e4100d6790e0822b8905608679180ac34ca0bd45bf7ccc6c5f5218236d0eb93afc78bd117b9f02a6b7df258ea182dfaef5aad7", 
   1path: "m/44H/60H/0H",
   2want pub: "xpub6CpsfWjghR6XdCB8yDq7jQRpRKEDP2LT3ZRUgURF9g5xevB7YoTpogkFRqq5nQtVSN8YCMZo2CD8u4zCaxRv85ctCWmzEi9gQ5DBhBFaTNo", 
   3want priv: "xprv9yqXG1Cns3YEQi6fsCJ7NGV5sHPiyZcbgLVst61dbLYyn7qy1G9aFtRmaYp481ounqnVf9Go2ymQ4gmxZLEwYSRhU868aDk4ZxzGvqJVH"
   

   The correction and discussion can be found here https://github.com/btcsuite/btcutil/pull/161

2. add more tests for leading zero

   In the library https://github.com/btcsuite/btcutil and https://github.com/decred/dcrd all the tests that are listed here pass successfully, but there is an error on my case. Seed: "57fb1e450b8afb95c62afbcd49e4100d6790e0822b8905608679180ac34ca0bd45bf7ccc6c5f5218236d0eb93afc78bd117b9f02a6b7df258ea182dfaef5aad7", want pub: "xpub6CpsfWjghR6XdCB8yDq7jQRpRKEDP2LT3ZRUgURF9g5xevB7YoTpogkFRqq5nQtVSN8YCMZo2CD8u4zCaxRv85ctCWmzEi9gQ5DBhBFaTNo", want priv: "xprv9yqXG1Cns3YEQi6fsCJ7NGV5sHPiyZcbgLVst61dbLYyn7qy1G9aFtRmaYp481ounqnVf9Go2ymQ4gmxZLEwYSRhU868aDk4ZxzGvqJVH". The correction and discussion can be found here https://github.com/btcsuite/btcutil/pull/161

   eaa4e10ef2
3. 
   klim0v commented at 2:35 pm on April 7, 2020: none

   @luke-jr
4. 
   luke-jr commented at 2:14 pm on April 30, 2020: member

   This needs @sipa, not me
5. luke-jr added the label Proposed BIP modification on Apr 30, 2020
6. luke-jr requested review from sipa on Apr 30, 2020
7. luke-jr assigned sipa on Apr 30, 2020
8. 
   sipa commented at 6:19 pm on April 30, 2020: member

   @klim0v Does btcutil not fail the existing test vector 3? If not, in what way does this one differ?

   If we’re adding this, please make it a test vector 4 rather than squishing it into vector 3.

9. add test vector 4 c6f1d14ea3
10. 
    klim0v commented at 12:49 pm on May 21, 2020: none

    @sipa
11. klim0v cross-referenced this on Oct 19, 2020 from issue added test vector #5 for invalid extended keys by fametrano
12. klim0v cross-referenced this on Oct 19, 2020 from issue why not add leading zero bytes to make childkey 32 bytes long? by bibibong
13. 
    fametrano commented at 9:41 am on November 15, 2020: contributor

    NACK Unless I am missing something, a library not failing at test vector #3 would not fail at this new proposed case: e.g. see https://github.com/btclib-org/btclib/commit/0cab43454b876d190a743a7886d77ad8ed0e8255
14. 
    kallewoof commented at 1:22 pm on July 12, 2021: member

    Is this resolved and can be closed, or is there still an issue that needs addressing?
15. klim0v closed this on Jul 12, 2021

    ---

Contributors
klim0v luke-jr sipa fametrano kallewoof

Review Requested
sipa

Labels
Proposed BIP modification