Fix bip85 #934

pull scgbckbone wants to merge 2 commits into bitcoin:master from scgbckbone:fix_bip85 changing 1 files +10 −8

scgbckbone commented at 11:52 AM on June 25, 2020: contributor
1. changed parse256(IL) ≥ n or ki = 0 --to--> parse256(IL) is 0 or ≥ n as there is no new child key ki created via parse256(IL) + kpar (mod n) therefore it should be clear that we want to check if parse256(IL) is not 0 as in master key generation (bip32) not some ki that is not even defined.
2. also added incorrect key warning to XPRV part where it should be checked either
3. incorrect key warning is now placed in footnotes
fixed bip32 algo to copy master key creation instead of private2private; added same warning to XPRV part a5beb39040
moved duplicate segments to footnotes f6b935f308
scgbckbone cross-referenced this on Jun 30, 2020 from issue BIP85: Fix wrong test vector by azuchi
ethankosakovsky commented at 1:04 PM on July 6, 2020: contributor

ACK
luke-jr merged this on Aug 1, 2020
luke-jr closed this on Aug 1, 2020

Contributors