BIP0039: Introduce WLIPS (Word Lists Improvement Proposals) repository. #941

pull p2w34 wants to merge 2 commits into bitcoin:master from p2w34:bip0039-introduce-wlips-repo changing 2 files +12 −23
  1. p2w34 commented at 7:08 pm on June 30, 2020: none
  2. Introduce WLIPS (Word Lists Improvement Proposals) repository. 86a3c2b691
  3. p2w34 renamed this:
    Introduce WLIPS (Word Lists Improvement Proposals) repository.
    BIP0039: Introduce WLIPS (Word Lists Improvement Proposals) repository.
    on Jun 30, 2020
  4. unknown approved
  5. in bip-0039.mediawiki:9 in 86a3c2b691 outdated
     5@@ -6,7 +6,7 @@
     6           Pavol Rusnak <stick@satoshilabs.com>
     7           Aaron Voisine <voisine@gmail.com>
     8           Sean Bowe <ewillbefull@gmail.com>
     9-  Comments-Summary: Unanimously Discourage for implementation
    10+  Comments-Summary: The creation of word lists moved to a separate repo: https://github.com/p2w34/wlips
    


    luke-jr commented at 0:10 am on August 1, 2020:

    This doesn’t belong here.

    If you wish to leave a comment, put it at the Comments-URI wiki page. (But that’s for review of this BIP, not changes proposed to it.)


    p2w34 commented at 7:55 pm on August 1, 2020:
    I see. I revert the change to this line.
  6. in bip-0039.mediawiki:97 in 86a3c2b691 outdated
    89@@ -111,9 +90,17 @@ The described method also provides plausible deniability, because every passphra
    90 generates a valid seed (and thus a deterministic wallet) but only the correct one
    91 will make the desired wallet available.
    92 
    93-==Wordlists==
    94+==Word lists==
    95+
    96+[[https://github.com/p2w34/wlips|Creation of word lists moved to a separate repo]].
    97+There are multiple reasons behind it. The most important ones are:
    98+* word lists are not Bitcoin-specific
    


    luke-jr commented at 0:11 am on August 1, 2020:

    They are used by Bitcoin, so this doesn’t make sense.

    Altcoins copying Bitcoin isn’t a reason to exclude something from BIPs.


    p2w34 commented at 7:56 pm on August 1, 2020:
    I remove this argument
  7. luke-jr changes_requested
  8. luke-jr added the label Proposed BIP modification on Aug 1, 2020
  9. luke-jr cross-referenced this on Aug 1, 2020 from issue Adding BIP-39 wordlist in German (2nd try) by cr
  10. Apply review changes. 8fdfa557e7
  11. p2w34 requested review from luke-jr on Aug 5, 2020
  12. luke-jr approved
  13. luke-jr commented at 6:13 am on August 5, 2020: member

    Looks okay to me.

    Needs ACK from @slush0 @prusnak @voisine or @ebfull

  14. prusnak commented at 8:48 am on August 5, 2020: contributor
    NAK on removing the Wordlist section. I was never a fan of localized wordlists. This fragmentation of information makes the situation even worse. I think we should about keeping BIP39 in it’s original form (maybe even reducing it only to English wordlist) and if someone wants to create localized wordlists they should apply for a new BIP.
  15. p2w34 commented at 9:17 pm on August 6, 2020: none
    It would be great to set the direction. Peoples’ energy could be redirected to tackle the problem holistically, instead of being wasted on PRs which have no chances of being accepted. Hence this PR with the idea of pausing BIP0039 and suggesting to move work on word lists to a separate repo.
  16. luke-jr closed this on Aug 6, 2020

  17. luke-jr commented at 10:11 pm on August 6, 2020: member

    @p2w34 Sounds like you will need to make a new BIP for localized mnemonic codes. First step is to email the bitcoin-dev mailing list with the proposal and discuss it. Probably a good idea to get some wallets onboard.

    Once there’s a new BIP, perhaps @prusnak et al will consider a PR reducing this BIP to just English.

  18. p2w34 commented at 6:04 am on August 7, 2020: none
    @luke-jr, @prusnak I see. Let me then first do some progress on wlips by myself and then actually decide what to do. Thank you.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me