BIP 174 reformat WIP #953

pull rustyrussell wants to merge 3 commits into bitcoin:master from rustyrussell:bip-178-reformat changing 1 files +119 −226

rustyrussell commented at 5:59 AM on July 28, 2020: contributor

Tried using EBNF to specify the format, and reworked the definitions to explicitly reference this.

If this works, I'll rework the rest of the text to use unified <xxx> names as cross-references?

BIP 174: clarify format of proprietary extensions.

"Variable length string identifier" is not defined anywhere, and the suggestion
to use "0x00" is also deeply unclear.  I assumed it meant a nul-terminated
string!

Be explicit: you mean it must be a compact siz1\e unsigned int length, followed
by that many identifier bytes, followed by a compact size unsigned int subtype,
followed by optional keydata.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

c4deaf4ae0

BIP 0174: Reformat using EBNF (WIP!) 8fc7ffb8ec
fixup! BIP 0174: Reformat using EBNF (WIP!) 56e1c3698b
sipa commented at 6:19 AM on July 28, 2020: member

I believe the title is wrong here (BIP174, not BIP178).
rustyrussell renamed this:
~~BIP 178 reformat WIP~~
BIP 174 reformat WIP
on Jul 28, 2020

in bip-0174.mediawiki:68 in 56e1c3698b

 124 | +: A compact size unsigned integer representing the type.  This compact size unsigned integer must be minimally encoded, i.e. if the value can be represented using one byte, it must be represented as one byte.  This must be unique within a specific <nowiki><map></nowiki>.
 125 | +;<tt><nowiki><keylen></nowiki></tt>
 126 | +: The compact size unsigned integer containing the combined length of <nowiki><keytype></nowiki> and <nowiki><keydata></nowiki>.
 127 | +;<tt><nowiki><valuelen></nowiki></tt>
 128 | +: The compact size unsigned integer containing the combined length of <nowiki><valuedata></nowiki>.
 129 | +;<tt><nowiki><mafic></nowiki></tt>

niftynei commented at 3:46 PM on July 28, 2020:

;<tt><nowiki><magic></nowiki></tt>

niftynei commented at 3:52 PM on July 28, 2020: none

spotted a typo!

in bip-0174.mediawiki:110 in 56e1c3698b

 252 | +** <nowiki><valuedata></nowiki> The transaction in network serialization format the current input spends from. This should only be present for inputs which spend non-segwit outputs. However, if it is unknown whether an input spends a segwit output, this type should be used.
 253 | +*** <tt><nowiki><transaction></nowiki></tt>
 254 | +
 255 | +* <nowiki><keytype></nowiki>: Witness UTXO <tt>PSBT_IN_WITNESS_UTXO = 0x01</tt>
 256 | +** <nowiki><keydata></nowiki>: None.
 257 | +** <nowiki><valuedata></nowiki> The entire transaction output in network serialization which the current input spends from. This should only be present for inputs which spend segwit outputs, including P2SH embedded ones.

niftynei commented at 3:53 PM on July 28, 2020:

** <nowiki><valuedata></nowiki> The entire transaction output (amount + scriptPubkey) in network serialization which the current input spends from. This should only be present for inputs which spend segwit outputs, including P2SH embedded ones.

luke-jr commented at 2:48 AM on August 1, 2020: member

@achow101
luke-jr added the label Proposed BIP modification on Aug 1, 2020
Sjors commented at 10:50 AM on April 30, 2021: member

If there's anything left to do here after #1055, it needs rebase...
murchandamus commented at 5:53 PM on April 24, 2024: contributor

@rustyrussell: Are you still working on this?
murchandamus added the label PR Author action required on May 8, 2024
murchandamus commented at 5:32 PM on May 20, 2024: contributor

I see that discussion on #1055 mentions that many of the changes proposed in this PR were incorporated in #1055. Since this PR has had unaddressed review comments for almost four years, and there was no response in the past almost four weeks whether it is still in progress, I assume this PR is either obsolete or abandoned. If that is an incorrect assessment, please let us know so we can either reopen this PR, or just open a new PR.
murchandamus closed this on May 20, 2024

Contributors

Labels

Proposed BIP modification PR Author action required

Linked (view graph)

#1055 BIP 174: Reformat, reorganize, and mark final