BIP155: clarify variable integer format and change time to fixed 32 bit #967

1. 
   vasild commented at 9:49 am on August 13, 2020: contributor

   • Clarify that by VARINT (variable integer) we mean CompactSize, not VARINT (as in the source code) (huh!?). Relevant IRC discussion: http://www.erisian.com.au/bitcoin-core-dev/log-2020-07-27.html#l-94

   • Change time to fixed 32 bits as that will work until year 2106, not just 2038 and takes 1 byte less than a variable integer format.

2. BIP155: change "time" to fixed 32 bit unsigned

   32 bit unsigned can represent time up to year 2106
   (32 bit signed is limited to just 2038).
   
   So, we don't need to have "time" encoded as variable integer which would
   take 5 bytes instead of 4.

   2c7630ec61
3. vasild force-pushed on Aug 13, 2020
4. 
   vasild commented at 9:54 am on August 13, 2020: contributor

   cc @jonasschnelli @luke-jr - this touches your suggestions.
5. 
   vasild commented at 9:55 am on August 13, 2020: contributor

   Render preview
6. vasild cross-referenced this on Aug 13, 2020 from issue BIP155: include changes from followup discussions by vasild
7. 
   vasild commented at 10:00 am on August 13, 2020: contributor

   cc also @laanwj as the author of BIP155 and @sipa who was involved in the VARINT vs CompactSize discussion.
8. luke-jr added the label Proposed BIP modification on Aug 20, 2020
9. vasild cross-referenced this on Aug 25, 2020 from issue Tor v3 support by vasild
10. 
    sipa commented at 7:37 pm on September 16, 2020: member

    LGTM
11. in bip-0155.mediawiki:64 in 44ff4bfe03 outdated

    63 |-
    64-| <code>VARINT</code> (unsigned)
    65+| <code>CompactSize</code>
    66 | <code>services</code>
    67-| Service bits. A 64-wide bit field.
    68+| Service bits. A bit field that is 64-bit wide, encoded in [https://en.bitcoin.it/wiki/Protocol_documentation#Variable_length_integer CompactSize].
    

    ---

    ---

    

    jonatack commented at 6:19 pm on September 17, 2020:

    nit, s/64-bit wide/64 bits wide/

    ---

    

    vasild commented at 9:13 am on September 29, 2020:

    Done.
12. 
    jonatack commented at 6:20 pm on September 17, 2020: contributor

    Seems good
13. 
    laanwj commented at 8:04 pm on September 17, 2020: member

    ACK but agree with @jonatack nit
14. 
    troygiorshev commented at 2:32 am on September 23, 2020: none

    ACK
15. vasild cross-referenced this on Sep 29, 2020 from issue Complete the BIP155 implementation and upgrade to TORv3 by vasild
16. BIP155: clarify that "services" uses CompactSize

    The Bitcoin Core source code has `VARINT` type which is different than
    the "variable integer" format used all over the P2P protocol and also
    for the "services" field in this BIP. The latter is called `CompactSize`
    in some BIPs and also in the Bitcoin Core source code, thus use the word
    `CompactSize` to refer to it and link to its documentation.

    87ef5aaa7c
17. vasild force-pushed on Sep 29, 2020
18. 
    vasild commented at 9:14 am on September 29, 2020: contributor

    Addressed nit: s/64-bit wide/64 bits wide/
19. 
    laanwj commented at 2:59 pm on September 29, 2020: member

    re-ACK
20. 
    troygiorshev commented at 12:45 pm on September 30, 2020: none

    reACK
21. 
    jonatack commented at 1:42 pm on October 1, 2020: contributor

    ACK
22. luke-jr merged this on Oct 1, 2020
23. luke-jr closed this on Oct 1, 2020

    ---

24. vasild deleted the branch on Oct 1, 2020
25. MarcoFalke cross-referenced this on Jun 1, 2021 from issue p2p: fix ubsan addrman errors, make nTime truncation conversion explicit by jonatack

Contributors
vasild sipa jonatack laanwj troygiorshev

Labels
Proposed BIP modification