BIP-32: Minor grammar fixes #984

pull Enegnei wants to merge 2 commits into bitcoin:master from Enegnei:patch-1 changing 1 files +6 −6

Enegnei commented at 8:17 PM on August 30, 2020: contributor

Very small grammar fix of "keys" to "key." I checked across all the currently open PRs related to BIP-32 (#293, #575, #576, #695, #785, #885), and I don't think any of them have suggested this change yet.
Minor grammar fix a0481edf92
sipa commented at 8:28 PM on August 30, 2020: member

ACK
A few more minor grammar fixes / improvements 688b0dabab
Enegnei referenced this in commit 489de1bee0 on Aug 30, 2020

in bip-0032.mediawiki:214 in 688b0dabab

 210 | @@ -211,7 +211,7 @@ Private and public keys must be kept safe as usual. Leaking a private key means
 211 |  Somewhat more care must be taken regarding extended keys, as these correspond to an entire (sub)tree of keys.
 212 |  
 213 |  One weakness that may not be immediately obvious, is that knowledge of a parent extended public key plus any non-hardened private key descending from it is equivalent to knowing the parent extended private key (and thus every private and public key descending from it). This means that extended public keys must be treated more carefully than regular public keys.
 214 | -It is also the reason for the existence of hardened keys, and why they are used for the account level in the tree. This way, a leak of account-specific (or below) private key never risks compromising the master or other accounts.
 215 | +It is also the reason for the existence of hardened keys, and why they are used for the account level in the tree. This way, a leak of account-specific (or below) private keys never risks compromising the master or other accounts.

schildbach commented at 6:49 AM on August 31, 2020:

If you switch "key" to the plural, shouldn't the "s" from "risks" be removed?

Enegnei commented at 8:51 AM on August 31, 2020:

No, I think "risks" would stay as it is, because it's the verb for the subject "leak," not "keys." If you remove what's in the middle of the sentence:

This way, a leak ... never risks compromising the master or other accounts.

schildbach commented at 9:41 AM on August 31, 2020:

Ok, makes sense.

luke-jr commented at 4:11 PM on October 5, 2020: member

@sipa This was changed after your last ACK... re-ACK?
luke-jr added the label Proposed BIP modification on Oct 5, 2020
bitcoin deleted a comment on Apr 24, 2024
jonatack commented at 3:16 PM on April 24, 2024: contributor

ACK, no alteration of meaning in the text AFAICT.

Pinging @sipa for sign-off on the second commit.
jonatack renamed this:
~~BIP-32: Minor grammar fix~~
BIP-32: Minor grammar fixes
on Apr 24, 2024
sipa commented at 3:23 PM on April 24, 2024: member

ACK 688b0dabab2fcdadffe69bf1bdf5d4773b5be391
jonatack merged this on Apr 24, 2024
jonatack closed this on Apr 24, 2024
jonatack commented at 3:25 PM on April 24, 2024: contributor

Thanks @sipa.
bitcoin deleted a comment on Jun 10, 2024

Contributors

Labels

Proposed BIP modification

Linked (view graph)

#293 Update the implementations section of BIP0032.#575 add libwally as bip32 implementation #576 BIP32: Add links to libbitcoin implementation, update style.#695 [Trivial] typo fix in bip-0032 #785 BIP 32: Add simpler explanations where I got confused originally reading this.#885 BIP-32: fix RFC link